test(client): add integration test for RPC hook accumulation#576
Closed
test(client): add integration test for RPC hook accumulation#576
Conversation
Add integration test to verify that multiple RPC-providing extensions are all accessible when installed together. This test ensures that the BaseBuilder properly accumulates RPC hooks instead of replacing them. The test verifies: - TxPool RPC (base_transactionStatus) is reachable - Metering RPC (base_meterBlockByNumber) is reachable Both should work simultaneously when both extensions are installed. Closes base#458
Use vec![] macro instead of Vec::new() + push pattern to satisfy clippy::vec_init_then_push lint.
The jsonrpsee crate doesn't have a 'types' feature. Instead, use the separate jsonrpsee-types crate which provides the ErrorCode type.
Collaborator
🟡 Heimdall Review Status
|
refcell
reviewed
Feb 6, 2026
Move the test from bin/node/tests/ to crates/client/node/tests/ as the integration test belongs in the library crate, not the binary. Add required dev-dependencies to base-client-node and remove the now-unused dev-dependencies from the binary crate.
…ation-458 # Conflicts: # crates/client/node/Cargo.toml
Contributor
Author
|
@refcell Replaced , Could you run CI ? |
Contributor
|
I'm gonna close this out for now -- we can re-open later/if needed. |
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
fixed 2 small typos in code comments
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
fixed 2 small typos in code comments
mw2000
pushed a commit
that referenced
this pull request
Mar 7, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* tests pass, fixes in * proposer is running locally * fix test, still broken though * more detailed error * jank proxy * wrapper solution instead * cleanup * fix silly errors; * tweak forge test * docs for dgfProposeL2Output; * works locally * cleanup * forge fmt * chore: update ELFs * feat: add a range limit when computing ranges by gas * fix: fmt * feat: rename gas_limit to evm_gas_limit * fix: revert RANGE_PROOF_INTERVAL default value * fix: rename RANGE_PROOF_GAS_LIMIT to RANGE_PROOF_EVM_GAS_LIMIT * feat: replace tuples by Range type * chore: update comment * chore: add `single_small_block` test * fix: comment * fix: add a warning if no ranges were inserted in the database * feat: merge disjoint ranges if possible before splitting * fix: perf feedbacks --------- Co-authored-by: leruaa <aurelien.catinon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458
Reopened #563