Skip to content

fix(bin): Allows Consensus Bin to build#540

Merged
refcell merged 5 commits intomainfrom
fix/enable-serde-feat-flag
Jan 21, 2026
Merged

fix(bin): Allows Consensus Bin to build#540
refcell merged 5 commits intomainfrom
fix/enable-serde-feat-flag

Conversation

@refcell
Copy link
Copy Markdown
Contributor

@refcell refcell commented Jan 20, 2026

Summary

A missing feature flag prevented the failing consensus binary build.

@refcell refcell self-assigned this Jan 20, 2026
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 20, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@refcell refcell requested a review from danyalprout January 20, 2026 23:29
@refcell refcell added the F-bug Flag: Something isn't working label Jan 20, 2026
@refcell refcell requested a review from haardikk21 January 21, 2026 03:11
refcell and others added 4 commits January 21, 2026 14:53
* fixes

* more fixes

* chore(bin): Remove Unused CLI Flags (#549)

* chore(bin): remove unused cli flags

* fix(ci): formatting

* chore(bin): fix consensus binary logging (#550)
@refcell refcell enabled auto-merge January 21, 2026 20:30
@refcell refcell added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit c3d653f Jan 21, 2026
15 checks passed
@refcell refcell deleted the fix/enable-serde-feat-flag branch January 21, 2026 20:54
mw2000 pushed a commit that referenced this pull request Mar 7, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
mw2000 pushed a commit that referenced this pull request Mar 9, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
mw2000 pushed a commit that referenced this pull request Mar 16, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
* fix(bin): enable serde feat flag

* fixes

* fix(bin): More Consensus Binary Fixes (#548)

* fixes

* more fixes

* chore(bin): Remove Unused CLI Flags (#549)

* chore(bin): remove unused cli flags

* fix(ci): formatting

* chore(bin): fix consensus binary logging (#550)

* fix lockfile

* chore: remove comments in cargo toml
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
mw2000 pushed a commit that referenced this pull request Mar 19, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
mw2000 pushed a commit that referenced this pull request Mar 23, 2026
* fix: refactor fault-proof proposer to use task-based concurrency

- Convert sequential operations to concurrent tasks using task tracking
- Fix dashboard showing 0 values during proof generation
- Implement task spawning for game creation, defense, resolution, and bond claiming
- Add centralized task management with completion handling
- Ensure metrics collection runs independently of other operations

This prevents long-running operations (like proof generation) from blocking
metrics updates and other proposer activities.

* chore: better logging

* chore: better logging

* chore: nits

* chore: apply comments

* chore: make fmt happy

* chore: update log level

* fix: challenger game resolution metrics

Removed some unused code as well

* chore: apply comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-bug Flag: Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants