fix: eth_getBlockByNumber should return Latest if Pending is None#194
Merged
danyalprout merged 4 commits intobase:mainfrom Nov 12, 2025
Merged
fix: eth_getBlockByNumber should return Latest if Pending is None#194danyalprout merged 4 commits intobase:mainfrom
danyalprout merged 4 commits intobase:mainfrom
Conversation
Collaborator
✅ Heimdall Review Status
|
refcell
added a commit
that referenced
this pull request
Feb 18, 2026
### Description Ports the span batch bits to `op-alloy-protocol`. ### Provenance Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](op-rs/kona#695).
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
Co-authored-by: Ubuntu <ubuntu@op-geth-nodes.maas>
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Ubuntu <ubuntu@op-geth-nodes.maas>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* fix: eth_getBlockByNumber should return Latest if Pending is None * style: improve readibility of fn block_by_number * style: removing extra whitespaces in fn test_get_pending_block
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
Co-authored-by: Ubuntu <ubuntu@op-geth-nodes.maas>
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
Co-authored-by: Ubuntu <ubuntu@op-geth-nodes.maas>
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
Co-authored-by: Ubuntu <ubuntu@op-geth-nodes.maas>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178
get_block_by_number() function is updated to match the Geth's behaviour of returning Latest Block.