Skip to content

feat: initial implementation of flashblocks sub#144

Merged
refcell merged 4 commits intobase:mainfrom
steph-rs:feat/flashblocks-subscription
Dec 4, 2025
Merged

feat: initial implementation of flashblocks sub#144
refcell merged 4 commits intobase:mainfrom
steph-rs:feat/flashblocks-subscription

Conversation

@steph-rs
Copy link
Copy Markdown
Contributor

@steph-rs steph-rs commented Oct 28, 2025

Proposed solution, addressing #118

Implementation:

  • New base_subscribe RPC endpoint with newFlashblocks subscription kind
  • Returns full RpcBlock on each flashblock update (similar to eth_subscribe("newHeads"))
  • Follows reth's EthPubSub patterns using jsonrpsee subscriptions and broadcast channels
  • Only available when flashblocks enabled via --websocket-url flag

@steph-rs steph-rs mentioned this pull request Oct 28, 2025
Closed
@haardikk21
Copy link
Copy Markdown
Collaborator

haardikk21 commented Oct 28, 2025 •
edited
Loading

I wonder if instead of a new RPC method, we should override eth_subscribe with special handling in case params includes the newPendingTransactions subscription type

Edit: nevermind, i guess that doesn't allow consumers to use logs as the subscription type then. we want logs based off of flashblock data

Edit 2: i just saw your comment on the issue

@steph-rs
Copy link
Copy Markdown
Contributor Author

steph-rs commented Oct 28, 2025

@danyalprout please let me know what you think🙏

@steph-rs steph-rs marked this pull request as ready for review October 28, 2025 22:49
@haardikk21
Copy link
Copy Markdown
Collaborator

haardikk21 commented Oct 29, 2025

Could you add some tests for this? Probably in tests/rpc.rs

@haardikk21
Copy link
Copy Markdown
Collaborator

haardikk21 commented Nov 11, 2025 •
edited
Loading

cc @cody-wang-cb to take a look at this

@github-actions github-actions bot added the Stale label Nov 26, 2025
@base base deleted a comment from github-actions bot Nov 26, 2025
@haardikk21 haardikk21 removed the Stale label Nov 26, 2025
@refcell refcell force-pushed the feat/flashblocks-subscription branch from 4bccb73 to b64553b Compare December 4, 2025 19:52
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Dec 4, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@refcell refcell requested a review from danyalprout December 4, 2025 20:26
refcell
refcell reviewed Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ported these changes to the new test-utils setup. Won't approve since I've made a bunch of changes that could use another set of eyes.

@steph-rs
Copy link
Copy Markdown
Contributor Author

steph-rs commented Dec 4, 2025

now we are talking! @refcell it's nice to see new contributors here🔥

@refcell
Copy link
Copy Markdown
Contributor

refcell commented Dec 4, 2025

now we are talking! @refcell it's nice to see new contributors here🔥

Thx, LMK if I missed something and I'll fix it @steph-rs

danyalprout
danyalprout approved these changes Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thank you @steph-rs and @refcell!

I personally prefer the idea overriding the existing eth_subscribe if possible. I wonder if we could have eth_subscribe(ExtendedSubscriptionKind), where ExtendedSubscriptionKind = {...SubscriptionKind, NewFlashblocks, PendingLogs }.

This would:

  1. Keep it consistent with the rest of the Flashblock API's (that override the underlying eth_ RPC's)
  2. Should be backwards compatible with the existing eth_subscribe setup
  3. We could potentially override the existing newPendingTransactions event to use the Flashblocks pending state

Happy for us to merge this now and do a follow up to see if we can move it into the eth namespace.

@steph-rs
Copy link
Copy Markdown
Contributor Author

steph-rs commented Dec 4, 2025

I would be happy to try my best in follow-up. should we update the issue then?

@refcell
Copy link
Copy Markdown
Contributor

refcell commented Dec 4, 2025

I would be happy to try my best in follow-up. should we update the issue then?

How about we just open up a new issue and point the old issue to the new one? And yes, doing this in a follow-on PR will make it easier to prevent more git conflicts - if you could work in a follow-on pr that would be much appreciated!!

@refcell refcell merged commit 65a4278 into base:main Dec 4, 2025
9 checks passed
@danyalprout danyalprout mentioned this pull request Dec 5, 2025
Closed
refcell added a commit that referenced this pull request Feb 18, 2026
@refcell
feat(genesis): Arbitrary Support (#144)
e9be2e6 
### Description

In [`kona`](https://github.com/anton-rs/kona), we'd like to test against
arbitrary inputs for various points in the derivation pipeline.
implementing arbitrary across op-alloy input types enables this.

This PR implements
[`arbitrary::Arbitrary`](https://docs.rs/arbitrary/latest/arbitrary/trait.Arbitrary.html)
across all `op-alloy-genesis` crate types.
mw2000 pushed a commit that referenced this pull request Mar 9, 2026
@omahs @ratankaliani @mw2000
docs: fix typos (#144)
3b1169a 
* fix typo

* fix typo

* fix typos

---------

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
mw2000 pushed a commit that referenced this pull request Mar 16, 2026
@omahs @ratankaliani @mw2000
docs: fix typos (#144)
ceb55d7 
* fix typo

* fix typo

* fix typos

---------

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
@steph-rs @refcell
feat: initial implementation of flashblocks sub (#144)
5b4486e 
* feat: initial implementation of flashblocks sub

* feat: add tests for base_subscribe

* fix(node): remove old node/main.rs changes

* fix(flashbots-rpc): tests

---------

Co-authored-by: refcell <abigger87@gmail.com>
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
@omahs @ratankaliani @mw2000
docs: fix typos (#144)
7ea68c3 
* fix typo

* fix typo

* fix typos

---------

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
mw2000 pushed a commit that referenced this pull request Mar 19, 2026
@omahs @ratankaliani @mw2000
docs: fix typos (#144)
b1f18b5 
* fix typo

* fix typo

* fix typos

---------

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
mw2000 pushed a commit that referenced this pull request Mar 23, 2026
@omahs @ratankaliani @mw2000
docs: fix typos (#144)
b5f5d60 
* fix typo

* fix typo

* fix typos

---------

Co-authored-by: Ratan Kaliani <ratankaliani@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@refcell refcell refcell left review comments

@danyalprout danyalprout danyalprout approved these changes

@cody-wang-cb cody-wang-cb Awaiting requested review from cody-wang-cb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@steph-rs @haardikk21 @cb-heimdall @refcell @danyalprout