Fix: Use Counter for upstream_messages#102
Merged
danyalprout merged 3 commits intobase:mainfrom Sep 28, 2025
Merged
Conversation
danyalprout
approved these changes
Sep 28, 2025
0xsimulacra
pushed a commit
to 0xsimulacra/base-node-reth
that referenced
this pull request
Oct 1, 2025
danyalprout
added a commit
that referenced
this pull request
Feb 12, 2026
refcell
added a commit
that referenced
this pull request
Feb 18, 2026
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* add * docs * docs * docs * add * feat: add docker startup logic (#103) * add docker startup logic * add * fix: delete the span batch server * fix * spin up and spin down * add * add * add * fix: fetch proofs that failed on server correctly (#104) * rm outdated env * wip * docs: update * add docs * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* add * docs * docs * docs * add * feat: add docker startup logic (#103) * add docker startup logic * add * fix: delete the span batch server * fix * spin up and spin down * add * add * add * fix: fetch proofs that failed on server correctly (#104) * rm outdated env * wip * docs: update * add docs * docs
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* add * docs * docs * docs * add * feat: add docker startup logic (#103) * add docker startup logic * add * fix: delete the span batch server * fix * spin up and spin down * add * add * add * fix: fetch proofs that failed on server correctly (#104) * rm outdated env * wip * docs: update * add docs * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* add * docs * docs * docs * add * feat: add docker startup logic (#103) * add docker startup logic * add * fix: delete the span batch server * fix * spin up and spin down * add * add * add * fix: fetch proofs that failed on server correctly (#104) * rm outdated env * wip * docs: update * add docs * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* add * docs * docs * docs * add * feat: add docker startup logic (#103) * add docker startup logic * add * fix: delete the span batch server * fix * spin up and spin down * add * add * add * fix: fetch proofs that failed on server correctly (#104) * rm outdated env * wip * docs: update * add docs * docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR changes the type of the
upstream_messagesmetric from a Gauge to a Counter.Since it represents the total number of messages received.