Include zero-file incremental backups in always-incremental consolidation#995
Merged
pstorz merged 4 commits intobareos:masterfrom Nov 26, 2021
Conversation
80d418c to
d31e2e7
Compare
f9a7edc to
abaeba3
Compare
added 4 commits
November 26, 2021 10:37
Fixes bareos#1374 : AlwaysIncremental Backup Scheme: Consolidate job does not honor "Always Incremental Job Retention" with empty Incrementals
abaeba3 to
232e719
Compare
pstorz
approved these changes
Nov 26, 2021
CHANGELOG.md
Outdated
| - webui: introduce confirmation dialog on rerun and cancel job actions [PR #951] | ||
| - docs: update documentation of config data types [PR #962] | ||
| - Allow `release` command to be used in scripts [PR #961] | ||
| - Allow consolidation of zero-file incremental backups [PR #995] |
Member
There was a problem hiding this comment.
Suggested change
| - Allow consolidation of zero-file incremental backups [PR #995] | |
| - Include zero-file incremental backups in always-incremental consolidation [PR #995] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Consolidation jobs for always incremental do not include zero-files backups jobs, and so these jobs stay in the database unnecessarily.
This PR makes sure zero-file incremental backups do get included in consolidation.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests