Skip to content

Include zero-file incremental backups in always-incremental consolidation#995

Merged
pstorz merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation
Nov 26, 2021
Merged

Include zero-file incremental backups in always-incremental consolidation#995
pstorz merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Nov 23, 2021

Description:

Consolidation jobs for always incremental do not include zero-files backups jobs, and so these jobs stay in the database unnecessarily.

This PR makes sure zero-file incremental backups do get included in consolidation.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@pstorz pstorz self-requested a review November 24, 2021 11:43
@pstorz pstorz changed the title zero file backup in always incremental consolidation Include zero-file incremental backups in always-incremental consolidation Nov 24, 2021
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation branch 2 times, most recently from 80d418c to d31e2e7 Compare November 24, 2021 12:45
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation branch 3 times, most recently from f9a7edc to abaeba3 Compare November 25, 2021 12:06
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation branch from abaeba3 to 232e719 Compare November 26, 2021 09:38
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you!

CHANGELOG.md Outdated
- webui: introduce confirmation dialog on rerun and cancel job actions [PR #951]
- docs: update documentation of config data types [PR #962]
- Allow `release` command to be used in scripts [PR #961]
- Allow consolidation of zero-file incremental backups [PR #995]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Allow consolidation of zero-file incremental backups [PR #995]
- Include zero-file incremental backups in always-incremental consolidation [PR #995]

@pstorz pstorz merged commit a80a466 into bareos:master Nov 26, 2021
@pstorz pstorz deleted the dev/alaaeddineelamri/master/zero-file-backup-in-always-incremental-consolidation branch November 26, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants