ua_restore: Add additional client info for restore report#1374
Merged
pstorz merged 3 commits intobareos:masterfrom Feb 14, 2023
Merged
Conversation
alaaeddineelamri
suggested changes
Feb 13, 2023
Contributor
alaaeddineelamri
left a comment
There was a problem hiding this comment.
Misplaced placeholder, otherwise everything is in order
core/src/dird/restore.cc
Outdated
Comment on lines
+566
to
+567
| " Restore Client: %s\n" | ||
| " Start time: %s\n" | ||
| " Start time: \"%s\" %s\n" |
Contributor
There was a problem hiding this comment.
the placeholder is misplaced: the information is displayed with Start Time instead of Restore Client
4d525ba to
93e47dd
Compare
alaaeddineelamri
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Adds the client information to restore reports that is also found on backup reports, e.g. current os.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality