database: Add index on jobmedia mediaid,jobid#958
Merged
sduehr merged 5 commits intobareos:masterfrom Nov 3, 2021
bruno-at-bareos:dev/bruno/4908-index_mediaid-jobid
Merged
database: Add index on jobmedia mediaid,jobid#958sduehr merged 5 commits intobareos:masterfrom bruno-at-bareos:dev/bruno/4908-index_mediaid-jobid
sduehr merged 5 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/4908-index_mediaid-jobid
Conversation
sduehr
requested changes
Oct 18, 2021
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks, some changes are necessary.
sduehr
requested changes
Oct 25, 2021
Member
sduehr
left a comment
There was a problem hiding this comment.
Looks like only a "," is missing, everything else looks good.
sduehr
requested changes
Oct 27, 2021
Member
sduehr
left a comment
There was a problem hiding this comment.
I fear we have to remove the IF NOT EXISTS with CREATE INDEX that I've proposed earlier, I forgot the we have to support RHEL/CentOS 7 which comes with PostgreSQL 9.2 by default, but this only work with PostgreSQL since 9.5.
This extra index boost performance on large table (400x) Close CR#4908, Fix TT4200733 - Catalog version is now 2210 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- Create index MediaId,JobId also for mysql,sqlite3 - update cats.h with new version Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: sduehr <stephan.duehr@bareos.com>
Obsoleted PG 9.2 still present in Centos 7 Co-authored-by: sduehr <stephan.duehr@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extra index boost performance on large table (400x)
Close CR#4908, Fix TT4200733
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing