systemtests: configurable database credentials#950
Merged
Conversation
arogge
previously requested changes
Oct 7, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
You have other commits on that branch that you probably don't want in this PR.
Also the not-so-nice XXX_REPLACE_WITH_DATABASE_DRIVER_XXX is currently required so you can run the tests with the different db backends without rerunning cmake and recompiling.
Other than that, there are also probably a lot more catalog configuration files in the systemtests directory that you did not (yet) touch.
systemtests/tests/python-bareos/etc/bareos/bareos-dir.d/catalog/MyCatalog.conf.in
Outdated
Show resolved
Hide resolved
This changes makes the PostgreSQL database configuration for systemtests simpler. Before it has be necessary to configure two database roles, one for the current system user and one for the database user "regress". The database admin scripts did run as the system user, while the Bareos use the "regress" database user. This did also require to adapt a PostgreSQL configuration file. With this change, only database one role and no change to the PostgreSQL default configuration is required. For using the system user, run cmake with following parameter: cmake -Dsystemtest_db_user=$USER ... When systemtest_db_user is not given as parameter, the old default "regress" is used.
f2e43d7 to
fb51dbe
Compare
arogge
approved these changes
Oct 8, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Works exactly like advertised. Great work, thank you!
Have a nice weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes makes the PostgreSQL database configuration
for systemtests simpler.
Before it has be necessary to configure two database roles,
one for the current system user and one for the database user "regress".
The database admin scripts did run as the system user,
while the Bareos use the "regress" database user.
This did also require to adapt a PostgreSQL configuration file.
With this change, only database one role and no change
to the PostgreSQL default configuration is required.
For using the system user, run cmake with following parameter:
cmake -Dsystemtest_db_user=$USER ...
When systemtest_db_user is not given as parameter, the old default "regress" is used.
This PR includes commits from PR #947
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing