Systemtest python-bareos: split tests in separate files#944
Merged
joergsteffens merged 4 commits intomasterfrom Sep 30, 2021
Merged
Systemtest python-bareos: split tests in separate files#944joergsteffens merged 4 commits intomasterfrom
joergsteffens merged 4 commits intomasterfrom
Conversation
69f1bba to
695b0bb
Compare
joergsteffens
added a commit
that referenced
this pull request
Sep 30, 2021
bd690bf to
f59731d
Compare
joergsteffens
added a commit
that referenced
this pull request
Sep 30, 2021
f59731d to
c598340
Compare
arogge
approved these changes
Sep 30, 2021
Split monolitic systemtests/tests/python-bareos/python-bareos-unittest.py into one file per test class. Move commonly used functionality to modules in systemtests/python-modules/bareos_unittest/. Use ``unittest discover`` to run all Python tests in the directory named test_*.py.
Run each Python file (test_*.py) as a separate test.
Refactor python-pam to use the systemtest Python module.
c598340 to
fa4f5c7
Compare
benibr
pushed a commit
to benibr/bareos
that referenced
this pull request
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split monolitic systemtests/tests/python-bareos/python-bareos-unittest.py
into one file per test class.
Move commonly used functionality to modules in
systemtests/python-modules/bareos_unittest/.
Run each Python file (test_*.py) as a separate ctest.
Reuse the
bareos_unittestalso from python-pam.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing