webui: fix possible issues due to PAM misconfiguration#936
Merged
Conversation
f7b8ce6 to
fafe231
Compare
joergsteffens
approved these changes
Sep 29, 2021
Member
joergsteffens
left a comment
There was a problem hiding this comment.
I added an error message for a specific case and tried to clarify the example configuration. Besides of this, I fully agree with this change.
Feel free to stash my commit into yours.
Check if UsePAMAuthentication is enabled on configured console in DIR, if not do not proceed with authentication. Fixes #1191: The web interface runs under any login and password
cf0d068 to
fbceecb
Compare
Contributor
Author
|
Thanks for the additions and the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if UsePAMAuthentication is enabled on configured console
in DIR, if not do not proceed with authentication.
Fixes #1191: The web interface runs under any login and password
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing