Skip to content

Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4#1191

Merged
pstorz merged 30 commits intobareos-21from
dev/pstorz/bareos-21/backport-PR-1179
Jun 24, 2022
Merged

Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4#1191
pstorz merged 30 commits intobareos-21from
dev/pstorz/bareos-21/backport-PR-1179

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Jun 22, 2022

Backport of PR #1179 to bareos-21

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

pstorz added 23 commits June 22, 2022 14:35
(cherry picked from commit 5b2e690)
(cherry picked from commit a82fd24)
(cherry picked from commit d91e285)
(cherry picked from commit 7297eec)
(cherry picked from commit 9d062fe)
(cherry picked from commit 8a5cf75)
(cherry picked from commit 2a1b747)
(cherry picked from commit 552a4d6)
so that we can disable python2 with -DENABLE_PYTHON2=no so that it is
not detected even if available.

(cherry picked from commit b13caee)
@bruno-at-bareos bruno-at-bareos self-assigned this Jun 22, 2022
@bruno-at-bareos bruno-at-bareos self-requested a review June 22, 2022 13:06
joergsteffens pushed a commit to joergsteffens/bareos that referenced this pull request Jun 22, 2022
Check if UsePAMAuthentication is enabled on configured console
in DIR, if not do not proceed with authentication.

Fixes bareos#1191: The web interface runs under any login and password
@pstorz pstorz force-pushed the dev/pstorz/bareos-21/backport-PR-1179 branch from cd0fd8e to a0a6a90 Compare June 23, 2022 12:37
@bruno-at-bareos
Copy link
Contributor

@pstorz could you please also fix the following missing backport

Plugin 'fix copyright year' would modify 'core/cmake/BareosFindAllLibraries.cmake'
Plugin 'fix copyright year' would modify 'core/src/droplet/libdroplet/CMakeLists.txt'
Plugin 'clang-format check' would modify 'core/src/droplet/libdroplet/include/droplet/cdmi/crcmodel.h'
Plugin 'cmake format' would modify 'core/src/lib/CMakeLists.txt'
Plugin 'fix copyright year' would modify 'core/src/lib/CMakeLists.txt'

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside copyright year see previous comment,
there's also a missing line entry in changelog concerning the removed platforms.

- build: Add support for Ubuntu 22.04, Fedora 36, EL 9, openSUSE 15.4 [PR #1191]

### Changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed support for openSUSE 15.2 and Fedora 34 ?

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks, ready to merge.

@pstorz pstorz merged commit 920c77b into bareos-21 Jun 24, 2022
@pstorz pstorz deleted the dev/pstorz/bareos-21/backport-PR-1179 branch June 24, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants