Skip to content

docs: update vmware plugin documentation#921

Merged
pstorz merged 2 commits intomasterfrom
dev/pstorz/master/update-vmware-docs
Sep 10, 2021
Merged

docs: update vmware plugin documentation#921
pstorz merged 2 commits intomasterfrom
dev/pstorz/master/update-vmware-docs

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Sep 10, 2021

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@pstorz pstorz requested a review from sduehr September 10, 2021 08:46
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Can be merged.

pstorz added a commit that referenced this pull request Sep 10, 2021
@pstorz pstorz force-pushed the dev/pstorz/master/update-vmware-docs branch from cd13d95 to 2e1a49a Compare September 10, 2021 13:51
@pstorz pstorz merged commit 52c9974 into master Sep 10, 2021
@pstorz pstorz deleted the dev/pstorz/master/update-vmware-docs branch September 10, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants