scripts: Fix logrotate by adding su instruction#918
Merged
arogge merged 2 commits intobareos:masterfrom Sep 9, 2021
bruno-at-bareos:dev/bruno/Fix_US4837_logrotate_su
Merged
scripts: Fix logrotate by adding su instruction#918arogge merged 2 commits intobareos:masterfrom bruno-at-bareos:dev/bruno/Fix_US4837_logrotate_su
arogge merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/Fix_US4837_logrotate_su
Conversation
Contributor
Author
|
After merge todo : backport to all supported versions for next minor release. |
Fixes #1232: bareos logrotate errors Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
arogge
approved these changes
Sep 9, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the effort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1232 : bareos logrotate errors
Adding back su directive with correct dir user and group (variables from cmake call)
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
This PR should superseed PR#917
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
Variable and function names are meaningfulCode comments are correct (logically and spelling)Required documentation changes are present and part of the PRbareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing