Skip to content

dird: fix odd even weeks parsing bug in schedule [Backport 1210]#1232

Merged
pstorz merged 3 commits intobareos:bareos-21from
bruno-at-bareos:dev/bruno/bareos-21/backport-1210-dird-fix-odd-even-weeks-parsing-bug-in-schedule
Aug 23, 2022
Merged

dird: fix odd even weeks parsing bug in schedule [Backport 1210]#1232
pstorz merged 3 commits intobareos:bareos-21from
bruno-at-bareos:dev/bruno/bareos-21/backport-1210-dird-fix-odd-even-weeks-parsing-bug-in-schedule

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Aug 16, 2022 •
edited by pstorz
Loading

This PR is a Backport of PR #1210 to bareos-21.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 16, 2022 14:29
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/bareos-21/backport-1210-dird-fix-odd-even-weeks-parsing-bug-in-schedule branch 2 times, most recently from 9b48845 to cbd23da Compare August 16, 2022 16:40
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/bareos-21/backport-1210-dird-fix-odd-even-weeks-parsing-bug-in-schedule branch from cbd23da to 77d9ab6 Compare August 18, 2022 10:10
@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Aug 22, 2022

The failed is linked to failing alma mirrors. please retrigger.

@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Aug 23, 2022

Can be reviewed and accepted the build and test are green https://jenkins.bareos.com/job/bareos-RepoTests/job/PR-1232-SwRepoTests/

@pstorz pstorz merged commit b613aef into bareos:bareos-21 Aug 23, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/bareos-21/backport-1210-dird-fix-odd-even-weeks-parsing-bug-in-schedule branch August 23, 2022 08:32
joergsteffens pushed a commit to joergsteffens/bareos that referenced this pull request Feb 15, 2023
@bruno-at-bareos @pstorz
scripts: Fix logrotate by adding su instruction
0017b32 
Fixes bareos#1232: bareos logrotate errors

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit 2f32489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

is a backport to 21

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bruno-at-bareos @pstorz @HediBenFraj