Fix Issue #1334: Allow removal of orphaned storages from catalog#912
Merged
arogge merged 9 commits intobareos:masterfrom Sep 22, 2021
Conversation
arogge
pushed a commit
to arogge/bareos
that referenced
this pull request
Aug 18, 2021
Changes wording to indicate better that paths may vary. Fixes bareos#912: wrong configuration path for apache
68fb3d8 to
e042401
Compare
arogge
pushed a commit
to arogge/bareos
that referenced
this pull request
Sep 13, 2021
Changes wording to indicate better that paths may vary. Fixes bareos#912: wrong configuration path for apache (cherry picked from commit b89087d)
arogge
pushed a commit
to arogge/bareos
that referenced
this pull request
Sep 13, 2021
Changes wording to indicate better that paths may vary. Fixes bareos#912: wrong configuration path for apache (cherry picked from commit b89087d)
arogge
requested changes
Sep 15, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
This looks really great. A lot of effort not only adding the feature to dbcheck, but also a good start to move dbcheck functionality into the director itself (where I think it belongs in the first place).
There are only a few simple changes, that I would like to see (mostly adding missing license headers).
I still have to try it out though.
ecd7038 to
a3a114b
Compare
arogge
requested changes
Sep 22, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
I tested it and it worked great. However, I felt the messages were a bit too verbose, so I added suggestions for string changes, what will probably also require changes to the systemtest (sorry for that).
But besides the texts, I'm really happy and would love to merge the PR!
Moved helper functions to another file, and changed certain functions arguments
system:multiplied_device now also tests the `delete storage` command
a3a114b to
dfac0ab
Compare
arogge
approved these changes
Sep 22, 2021
bsperduto
pushed a commit
to bsperduto/bareos
that referenced
this pull request
Sep 23, 2021
Changes wording to indicate better that paths may vary. Fixes bareos#912: wrong configuration path for apache (cherry picked from commit b89087d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description:
Fix for bug 1334: After deleting storage from the configuration, it persists in the catalog db. Now such storages can be deleted by either
dbcheckor thedelete storagecommand inbconsole.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests