Skip to content

webui: quote restore command parameters#893

Merged
frb121 merged 2 commits intomasterfrom
dev/fbergkemper/master/bug-0001020
Jul 21, 2021
Merged

webui: quote restore command parameters#893
frb121 merged 2 commits intomasterfrom
dev/fbergkemper/master/bug-0001020

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Jul 15, 2021

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Maybe we should consider also quoting the replace option?

frb121 added 2 commits July 19, 2021 15:03
Fixes #1020: Can not restore a client with spaces in its name
@frb121 frb121 force-pushed the dev/fbergkemper/master/bug-0001020 branch from 82fac07 to e726cc9 Compare July 19, 2021 13:04
@frb121 frb121 requested a review from arogge July 19, 2021 13:05
@frb121
Copy link
Contributor Author

frb121 commented Jul 19, 2021

Looks ok. Maybe we should consider also quoting the replace option?

See above.

Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frb121 frb121 merged commit 7ff1f80 into master Jul 21, 2021
@frb121 frb121 deleted the dev/fbergkemper/master/bug-0001020 branch July 21, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants