Skip to content

webui: provide a notification that NDMP restores are NOT supported by webui#1020

Merged
pstorz merged 3 commits intomasterfrom
dev/fbergkemper/master/s5028
Dec 13, 2021
Merged

webui: provide a notification that NDMP restores are NOT supported by webui#1020
pstorz merged 3 commits intomasterfrom
dev/fbergkemper/master/s5028

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Dec 9, 2021 •
edited by pstorz
Loading

webui: provide a notification that NDMP restores are NOT supported by webui
docs: add section that NDMP restores are NOT supported by webui

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@frb121 frb121 self-assigned this Dec 9, 2021
@frb121 frb121 requested a review from pstorz December 9, 2021 16:27
pstorz
pstorz requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately webui:admin_restore test fails always.

@frb121 frb121 force-pushed the dev/fbergkemper/master/s5028 branch 2 times, most recently from 4a6c784 to 6c7c1e1 Compare December 10, 2021 12:54
@frb121
Copy link
Contributor Author

frb121 commented Dec 10, 2021

Unfortunately webui:admin_restore test fails always.

There was a misplaced early bsock->disconnect() call, that broke the final restore step. I've fixed and updated the PR. Also I've added another commit for the documentation.

@frb121 frb121 requested a review from pstorz December 10, 2021 13:02
pstorz
pstorz requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Title is misleading. Better:
webui: provice a notification that NDMP restores are NOT supported by webui.

Also please add a bit more info to the commit descriptions:

docs: add restore section limitations -> docs: add section that NDMP restores are not supported by webui.

webui: provide a restore support notification for NDMP backups -> webui: provide a notification that NDMP restores are not supported by webui. (Same as PR title)

@frb121 frb121 force-pushed the dev/fbergkemper/master/s5028 branch from 6c7c1e1 to de617c2 Compare December 13, 2021 10:18
@frb121 frb121 changed the title webui: provide a restore support notification for NDMP backups webui: provide a notification that NDMP restores are NOT supported by webui Dec 13, 2021
@pstorz pstorz self-requested a review December 13, 2021 10:23
pstorz
pstorz approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If the build passes with all checks green we can merge.

@frb121 frb121 force-pushed the dev/fbergkemper/master/s5028 branch 4 times, most recently from b1b7a05 to 5993460 Compare December 13, 2021 10:29
@pstorz pstorz force-pushed the dev/fbergkemper/master/s5028 branch from 5993460 to 1041304 Compare December 13, 2021 10:33
@frb121
Copy link
Contributor Author

frb121 commented Dec 13, 2021

PR Title is misleading. Better: webui: provice a notification that NDMP restores are NOT supported by webui.

Also please add a bit more info to the commit descriptions:

docs: add restore section limitations -> docs: add section that NDMP restores are not supported by webui.

webui: provide a restore support notification for NDMP backups -> webui: provide a notification that NDMP restores are not supported by webui. (Same as PR title)

Done

@pstorz pstorz merged commit f99d8ba into master Dec 13, 2021
@pstorz pstorz deleted the dev/fbergkemper/master/s5028 branch December 13, 2021 12:11
bsperduto pushed a commit to bsperduto/bareos that referenced this pull request Dec 19, 2021
@frb121
webui: quote restore command parameters
52827c8 
Fixes bareos#1020: Can not restore a client with spaces in its name
alaaeddineelamri pushed a commit to alaaeddineelamri/bareos that referenced this pull request Feb 7, 2022
@frb121
webui: quote restore command parameters
1f656eb 
Fixes bareos#1020: Can not restore a client with spaces in its name

(cherry picked from commit 52827c8)
alaaeddineelamri pushed a commit to alaaeddineelamri/bareos that referenced this pull request Feb 7, 2022
Merge pull request bareos#894 from bareos/dev/fbergkemper/bareos-20/b…
815f443 
…ug-0000971

webui: backport to fix issue bareos#971 and issue bareos#1020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@frb121 frb121

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frb121 @pstorz