Skip to content

webui: set default extras as empty array to prevent compact() errors#829

Merged
pstorz merged 2 commits intomasterfrom
dev/fbergkemper/master/bug-0001205
Jun 8, 2021
Merged

webui: set default extras as empty array to prevent compact() errors#829
pstorz merged 2 commits intomasterfrom
dev/fbergkemper/master/bug-0001205

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented May 31, 2021

PHP compact() function will create php error when $args is an
empty array.

See: zendframework/zend-view#170

Fixes #1205: HeadLink.php error with PHP 7.3

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

frb121 added 2 commits May 31, 2021 16:56
PHP compact() function will create php error when $args is an
empty array.

See: zendframework/zend-view#170

Fixes #1205: HeadLink.php error with PHP 7.3
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@pstorz pstorz merged commit 6515c26 into master Jun 8, 2021
@pstorz pstorz deleted the dev/fbergkemper/master/bug-0001205 branch June 8, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants