systemd: switch service from forking to simple (foreground)#824
Merged
systemd: switch service from forking to simple (foreground)#824
Conversation
joergsteffens
added a commit
that referenced
this pull request
May 27, 2021
9b01abd to
99dc6b8
Compare
arogge
reviewed
Jun 10, 2021
pstorz
reviewed
Jun 14, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
The commit messages are too wide, should be wrapped around 72 chars.
Other than that everything looks good.
The service type forking caused problems on newer systemd versions (Fedora 34). Using type=simple and starting the daemons without forking has the advantage, that daemon messages to stdout and stderr are shown with systemctl status or journalctl. This includes the daemon debug messages, when set into debug mode. Removed the PIDFile directive, as it is only required for Type=forking and will be incorrect, as soon as listening port is changed in the Bareos configuration. Removed the no longer supported (and never really used) directive StandardOutput=syslog Director: Exit code 1 is no longer treated as success. This has been introduced as a workaround, but is no longer required.
It has been prepared for the Bareos daemon pid files, but is no longer (or has never been) used.
31ff869 to
4128f11
Compare
Member
Author
|
Adapt the commit messages and rebased on master. |
frb121
pushed a commit
that referenced
this pull request
Jun 21, 2021
pstorz
added a commit
that referenced
this pull request
Jun 29, 2021
As PR #824 was merged, we now are able to build Fedora34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service type forking caused problems on newer systemd versions (Fedora 34).
Using type=simple and starting the daemons without forking
has the advantage,
that daemon messages to stdout and stderr are shown with systemctl status or journalctl.
This includes the daemon debug messages, when set into debug mode.
Removed the no longer supported (and never really used)
StandardOutput=syslog
Director: Exit code 1 is no longer treated as success.
This has been introduced as a workaround, but is no longer required.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
Source code changes are understandableVariable and function names are meaningfulCode comments are correct (logically and spelling)Required documentation changes are present and part of the PRbareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests
Decision taken that a system- or unittest is required (if not, then remove this paragraph)The decision towards a systemtest is reasonable compared to a unittestTestname matches exactly what is being testedOutput of the test leads quickly to the origin of the fault