Merged
Conversation
joergsteffens
added a commit
that referenced
this pull request
Apr 14, 2021
b2cd696 to
9a293bc
Compare
joergsteffens
added a commit
that referenced
this pull request
Apr 14, 2021
9a293bc to
824603e
Compare
joergsteffens
added a commit
that referenced
this pull request
Apr 19, 2021
joergsteffens
added a commit
that referenced
this pull request
Apr 20, 2021
joergsteffens
added a commit
that referenced
this pull request
Apr 20, 2021
824603e to
e5f32c4
Compare
joergsteffens
added a commit
that referenced
this pull request
Apr 21, 2021
joergsteffens
added a commit
that referenced
this pull request
Apr 21, 2021
e5f32c4 to
bc2153d
Compare
Member
Author
|
I've been asked to implement the cmake Jansson dependencies with find_module, instead of ugly workaround for Solaris. I implemented this and also did some cleanup in the cmake files. When someone is reviewing this PR, please have a close look on following item, where I'm unsure:
|
joergsteffens
added a commit
that referenced
this pull request
Apr 21, 2021
bc2153d to
6081ca1
Compare
Without the library, the API 2 commands are not available. Implement find_package for Jansson, as otherwise Solaris would require special treatment.
jansson is a requirement when compiling the Director, so HAVE_JANSSON is no longer required.
This files have been used to initialize jansson with a custom memory management. While this have been useful in the past, the memory management have now be identical to the default. Therefore, these initialization is no longer required.
The message mode parameter is case-sensitiv and must be written upper-case.
6081ca1 to
3c2e57b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jansson library is required to be able to execute Bareos console commands in API 2 (json) mode.
This change gurantees that it is available when building.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing