Remove old regress tests by joergsteffens · Pull Request #780 · bareos/bareos

joergsteffens · 2021-03-28T18:27:30Z

The tests from regress/ have been deprecated in favor the systemtests/.
As they are no longer is use, this PR removes them.
A couple of useful tests are migrated to systemtests.

Thank you for contributing to the Bareos Project!

Please check

Short description and the purpose of this PR is present above this paragraph
Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

PR name is meaningful
Purpose of the PR is understood
Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
Commit descriptions are understandable and well formatted

Source code quality

Source code changes are understandable
Variable and function names are meaningful
Code comments are correct (logically and spelling)
Required documentation changes are present and part of the PR
check-sources --since-merge does not report any problems
git status should not report modifications in the source tree after building and testing

pstorz

Good work. It might make sense to see if we can merge some of the new tests or /and also of the existing tests together to get a better overall run performance. By using setup and cleanup steps

core/scripts/bareos-ctl-dir.in

systemtests/scripts/functions

systemtests/scripts/create_sparse_file.sh

systemtests/tests/python-bareos/testrunner

systemtests/tests/block-size/testrunner

systemtests/tests/fileset-multiple-include-blocks/testrunner

joergsteffens · 2021-05-17T08:34:43Z

This PR depends on #809 and should be merged after that.

joergsteffens · 2021-05-20T11:34:18Z

I think, I covered all requested changes. Also PR #809 is merged now, so this PR is rebased on it.
@pstorz : please review again.

pstorz

CHANGELOG.md is missing, I think that would make sense to add some info there
truncate-command/testrunner still seems to have the wrong comment,
Untracked files after build git status:
Untracked files:
(use "git add ..." to include in what will be committed)
Testing/
core/scripts/bareos-regress.conf
systemtests/tests/messages/testrunner:
bareos-check-sources --since-merge:
Plugin 'cmake format' would modify 'core/CTestScript.cmake.in'
Plugin 'clang-format check' would modify 'core/src/dird/ua_status.cc'
Plugin 'trailing newlines' would modify 'systemtests/tests/block-size/etc/bareos/bareos-dir.d/pool/Tape.conf'

systemtests/tests/truncate-command/testrunner

joergsteffens · 2021-06-04T13:50:37Z

I applied the requested changes and rebased to master again.

pstorz

Good work!

* replace "echo -n" with "printf", because "echo -n" does not work as expected on Solaris. * speed up stop scripts. Every test stops the 3 daemons. Verifying that a daemon is really stopped, takes around 1 second. This change reduces the required time to about 0,5s, which sums up to 80 (tests) * 3 (daemons) * 0,5s = 120s = 2m

Sort tests alphabetically.

The variables dir_plugin_binary_path, sd_plugin_binary_path and fd_plugin_binary_path have only been copies of DIR_PLUGINS_DIR_TO_TEST, SD_PLUGINS_DIR_TO_TEST and FD_PLUGINS_DIR_TO_TEST, if build against python. Removed, because they are redundant.

migrated from regress/

This change removes the regress directory, containing lots of old tests. The relevant tests have been migrated into systemtests. This change also removes references from the documentation to the old regress tests.

All tests that do set BackupDirectory set it to the same value (${tmp}/data). This is moved from the testrunner scripts to the environment file. The setup_data function no longer supports parameter, so parameter are removed from the calls. The function now uses the BackupDirectory variable.

While the execution of a command with exit code other than 0 is normally an error. The test scripts stop than with status error. However, when commands are executed with pipes, only the exit code of the last command is evaluated. With the option "pipefail", the first failing command sets the exit code. This is useful, because otherwise errors can occur unnoticed.

joergsteffens force-pushed the dev/joergs/master/remove-regress branch 2 times, most recently from 7f0b0a9 to fbb737f Compare April 1, 2021 10:31

joergsteffens marked this pull request as ready for review April 1, 2021 10:32

joergsteffens requested a review from pstorz April 12, 2021 09:20

joergsteffens marked this pull request as draft April 18, 2021 18:31

joergsteffens force-pushed the dev/joergs/master/remove-regress branch from fbb737f to 56cecc6 Compare April 19, 2021 08:56

joergsteffens marked this pull request as ready for review April 19, 2021 10:51

pstorz requested changes Apr 19, 2021

View reviewed changes

joergsteffens force-pushed the dev/joergs/master/remove-regress branch from 2afae24 to 2f14222 Compare April 26, 2021 13:16

joergsteffens force-pushed the dev/joergs/master/remove-regress branch 4 times, most recently from c9dd2df to 1baa170 Compare May 9, 2021 18:00

joergsteffens force-pushed the dev/joergs/master/remove-regress branch from 1baa170 to c038ede Compare May 17, 2021 08:27

joergsteffens force-pushed the dev/joergs/master/remove-regress branch from c038ede to 11c86d9 Compare May 20, 2021 11:31

joergsteffens requested a review from pstorz May 20, 2021 11:31

joergsteffens assigned pstorz May 20, 2021

pstorz force-pushed the dev/joergs/master/remove-regress branch 2 times, most recently from 85a336d to 72988ae Compare May 31, 2021 10:50

pstorz requested changes Jun 4, 2021

View reviewed changes

systemtests/tests/truncate-command/testrunner Outdated Show resolved Hide resolved

pstorz force-pushed the dev/joergs/master/remove-regress branch from 72988ae to 1da2bd0 Compare June 4, 2021 11:48

joergsteffens added a commit that referenced this pull request Jun 4, 2021

update CHANGELOG: remove old regression tests #780

952eb61

joergsteffens force-pushed the dev/joergs/master/remove-regress branch from 1da2bd0 to 952eb61 Compare June 4, 2021 13:47

joergsteffens requested a review from pstorz June 4, 2021 13:50

pstorz approved these changes Jun 7, 2021

View reviewed changes

joergsteffens mentioned this pull request Jun 18, 2021

systemtests: allow multiple tests per directory #857

Merged

12 tasks

pstorz pushed a commit that referenced this pull request Jun 21, 2021

update CHANGELOG: remove old regression tests #780

0e32af2

pstorz force-pushed the dev/joergs/master/remove-regress branch from 952eb61 to 0e32af2 Compare June 21, 2021 08:26

joergsteffens added 15 commits June 21, 2021 12:25

systemtests: cleanup

ff4b2b4

Sort tests alphabetically.

systemtest: add fileset-multiple-include-blocks test

126cb01

migrated from regress/

systemtest: add fileset-multiple-options-blocks test

dddb596

migrated from regress/

systemtest: add quota-softquota test

34d60be

migrated from regress/

systemtest: add sparse-file test

7c9da2d

migrated from regress/

systemtest: add truncate-command test

4321888

migrated from regress/

systemtest: add block-size test

4489e5d

migrated from regress/

systemtest python-bareos: add bvfs test

3565544

migrated from regress/

systemtest python-bareos: add dbcheck test

d2b6e4d

migrated from regress/

remove regress tests

74046cf

This change removes the regress directory, containing lots of old tests. The relevant tests have been migrated into systemtests. This change also removes references from the documentation to the old regress tests.

update CHANGELOG: remove old regression tests #780

d19597c

pstorz force-pushed the dev/joergs/master/remove-regress branch from 0e32af2 to d19597c Compare June 21, 2021 10:25

pstorz merged commit 54a788a into master Jun 21, 2021

pstorz deleted the dev/joergs/master/remove-regress branch June 21, 2021 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove old regress tests#780

Remove old regress tests#780
pstorz merged 15 commits intomasterfrom
dev/joergs/master/remove-regress

joergsteffens commented Mar 28, 2021 •

edited by pstorz

Loading

Uh oh!

pstorz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joergsteffens commented May 17, 2021

Uh oh!

joergsteffens commented May 20, 2021

Uh oh!

pstorz left a comment

Uh oh!

Uh oh!

joergsteffens commented Jun 4, 2021

Uh oh!

pstorz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

joergsteffens commented Mar 28, 2021 • edited by pstorz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you for contributing to the Bareos Project!

Please check

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

Source code quality

Uh oh!

pstorz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joergsteffens commented May 17, 2021

Uh oh!

joergsteffens commented May 20, 2021

Uh oh!

pstorz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joergsteffens commented Jun 4, 2021

Uh oh!

pstorz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joergsteffens commented Mar 28, 2021 •

edited by pstorz

Loading