contrib: add packaging for the contrib subproject by joergsteffens · Pull Request #768 · bareos/bareos

joergsteffens · 2021-03-23T14:16:56Z

Add packages
* bareos-contrib-director-python-plugins.install
* bareos-contrib-filedaemon-python-plugins.install
* bareos-contrib-tools

Renamed triggerjob to bareos-triggerjob to indicate, that it belongs to Bareos.

Removed support for RHEL4 from SPEC file. It is no longer used.

OP#4820

Thank you for contributing to the Bareos Project!

Please check

Short description and the purpose of this PR is present above this paragraph
Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

PR name is meaningful
Purpose of the PR is understood
Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
Commit descriptions are understandable and well formatted

Source code quality

Source code changes are understandable
Variable and function names are meaningful
Code comments are correct (logically and spelling)
Required documentation changes are present and part of the PR
check-sources --since-merge does not report any problems
git status should not report modifications in the source tree after building and testing

Tests

Decision taken that a system- or unittest is required (if not, then remove this paragraph)
The decision towards a systemtest is reasonable compared to a unittest
Testname matches exactly what is being tested
Output of the test leads quickly to the origin of the fault

robertoschwald · 2021-04-01T08:48:37Z

Hope this work is finished asap and leads to packages in https://download.bareos.org/bareos/contrib/.
The current contrib repo packages do not support Bareos 20, so I need to manually overwrite the mysql python files.

joergsteffens · 2021-05-06T09:41:22Z

This PR depends on improving the Bareos Python packaging, which is handled as separate task. As soon, as this is fixed, work on this PR can continue.

joergsteffens · 2022-04-06T18:21:55Z

Additionally, in docs/manuals/source/Appendix/Howtos/BackupOfThirdPartyDatabases.rst.inc please replace _mysqlbackups_ by @mysqlbackup@

Done.

and adapted for Python >= 3

Renamed bareos-tasks-plugins to bareos_tasks. Adapt file names to PEP8 (lowercase, no - in names). Adapt bareos_tasks.pssql to Bareos >= 20.

... and adapted it to Python 3. Uses sudo instead of subprocess preexec_fn function, which is not supported in subprocessors in Python 3.

Added option defaultsfile. Renamend option mysql_user to user, as the system user is meant, not the database user.

Cover the case of empty databases.

Added the contrib/fd-plugins path to PYTHONPATH, in order to test the Python modules by systemtests.

Add test for the contrib bareos_mysql_dump python module.

Adds Python 2 und 3 tests for the contrib bareos_tasks.mysql plugin.

Currently 4 systemtests do start/stop a MySQL/MariaDB daemon to perform their testing. This commits unifies the required functions. MariaDBs are treated as MySQL databases. Unfortenatly, initialisation differs. With this change, initialisation works with both databases.

done.

sduehr

Looks good now, thanks a lot!

joergsteffens added a commit that referenced this pull request Mar 23, 2021

updated CHANGELOG for #768

919e8e0

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 18ab6c8 to 919e8e0 Compare March 23, 2021 14:25

joergsteffens added a commit that referenced this pull request Mar 23, 2021

updated CHANGELOG for #768

8018c93

joergsteffens force-pushed the dev/joergs/master/contrib-build branch 2 times, most recently from 00b44ea to 60db5fb Compare March 26, 2021 16:53

joergsteffens added the onhold label May 6, 2021

joergsteffens added a commit that referenced this pull request Dec 22, 2021

updated CHANGELOG for #768

aa49416

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 60db5fb to c52128b Compare December 22, 2021 18:36

joergsteffens removed the onhold label Dec 22, 2021

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from c52128b to 146c929 Compare December 22, 2021 18:59

joergsteffens added a commit that referenced this pull request Dec 23, 2021

updated CHANGELOG for #768

ec7186e

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 372debb to 35bf863 Compare December 23, 2021 09:00

joergsteffens added a commit that referenced this pull request Dec 23, 2021

updated CHANGELOG for #768

418f59a

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 35bf863 to d6eaf10 Compare December 23, 2021 11:08

joergsteffens added a commit that referenced this pull request Dec 23, 2021

updated CHANGELOG for #768

02e16ab

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from d6eaf10 to ae478e9 Compare December 23, 2021 12:44

joergsteffens added a commit that referenced this pull request Feb 4, 2022

updated CHANGELOG for #768

eff7d71

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from aa25377 to eff7d71 Compare February 4, 2022 17:53

joergsteffens added a commit that referenced this pull request Feb 4, 2022

updated CHANGELOG for #768

b70bf61

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from eff7d71 to f0f410b Compare February 4, 2022 19:23

joergsteffens added a commit that referenced this pull request Feb 9, 2022

updated CHANGELOG for #768

ea14cdc

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 705f5ad to f4005fe Compare February 9, 2022 17:42

joergsteffens added a commit that referenced this pull request Feb 9, 2022

updated CHANGELOG for #768

7525a8d

joergsteffens force-pushed the dev/joergs/master/contrib-build branch 3 times, most recently from 58da2d6 to d20fda8 Compare February 10, 2022 15:45

joergsteffens marked this pull request as ready for review February 10, 2022 17:58

joergsteffens requested a review from sduehr February 10, 2022 17:59

joergsteffens added a commit that referenced this pull request Apr 6, 2022

updated CHANGELOG for #768

443c8dd

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from de3661d to e08eefd Compare April 6, 2022 12:34

joergsteffens requested a review from sduehr April 6, 2022 17:38

joergsteffens added a commit that referenced this pull request Apr 6, 2022

updated CHANGELOG for #768

98d43ff

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from 589bd26 to b773da7 Compare April 6, 2022 18:21

joergsteffens added 19 commits April 6, 2022 22:26

contrib bareos_mysql_dump: adapted for Bareos >=20

2a8a5d2

and adapted for Python >= 3

contrib: renamed bareos-tasks-plugins -> bareos_tasks

87262c6

Renamed bareos-tasks-plugins to bareos_tasks. Adapt file names to PEP8 (lowercase, no - in names). Adapt bareos_tasks.pssql to Bareos >= 20.

contrib bareos_tasks: adapted for Bareos >= 20

0dccab0

... and adapted it to Python 3. Uses sudo instead of subprocess preexec_fn function, which is not supported in subprocessors in Python 3.

contrib bareos_tasks.mysql: adapted to Bareos >= 20

640b79d

contrib bareos_tasks.mysql: add option defaultsfile

f2139f0

Added option defaultsfile. Renamend option mysql_user to user, as the system user is meant, not the database user.

contrib bareos_tasks.mysql: handle empty databases

8c6188c

Cover the case of empty databases.

contrib: cleanup

9ab5e27

bareos_elasticsearch/README.md

8deda58

contrib nagios_icinga: adapted to Bareos >= 20

58b527e

systemtest py2plug-fd-percona-xtrabackup: fixes

50180be

systemtests: add contrib to pythonpaths

dc83b3d

Added the contrib/fd-plugins path to PYTHONPATH, in order to test the Python modules by systemtests.

systemtest py3plug-fd-contrib-mysql_dump: initial

09dca60

Add test for the contrib bareos_mysql_dump python module.

systemtest py2plug-fd-contrib-bareos_tasks_mysql: initial

700963e

Adds Python 2 und 3 tests for the contrib bareos_tasks.mysql plugin.

updated CHANGELOG for #768

97292a8

systemtests python-bareos: fix for Python 2

6501d55

systemtests python-bareos: allow parameter for run_unittests.sh

56b906b

systemtests: check_log: improve failed job detection

7a8cdd0

Update link in SPONSORS

dbbdd5a

joergsteffens force-pushed the dev/joergs/master/contrib-build branch from b773da7 to dbbdd5a Compare April 6, 2022 20:26

sduehr approved these changes Apr 7, 2022

View reviewed changes

joergsteffens merged commit 0e7a3cd into master Apr 7, 2022

pstorz pushed a commit to arogge/bareos that referenced this pull request Apr 26, 2022

updated CHANGELOG for bareos#768

e000d89

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

contrib: add packaging for the contrib subproject#768

contrib: add packaging for the contrib subproject#768
joergsteffens merged 25 commits intomasterfrom
dev/joergs/master/contrib-build

joergsteffens commented Mar 23, 2021 •

edited by sduehr

Loading

Uh oh!

robertoschwald commented Apr 1, 2021

Uh oh!

joergsteffens commented May 6, 2021

Uh oh!

joergsteffens commented Apr 6, 2022

Uh oh!

sduehr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joergsteffens commented Mar 23, 2021 • edited by sduehr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you for contributing to the Bareos Project!

Please check

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

Source code quality

Tests

Uh oh!

robertoschwald commented Apr 1, 2021

Uh oh!

joergsteffens commented May 6, 2021

Uh oh!

joergsteffens commented Apr 6, 2022

Uh oh!

sduehr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joergsteffens commented Mar 23, 2021 •

edited by sduehr

Loading