Fix CommandACL bug that prevents messages to be seen#763
Conversation
0bb13b8 to
aefcce6
Compare
aefcce6 to
99abeb5
Compare
e025c74 to
7d6ebab
Compare
7d6ebab to
9c87f96
Compare
arogge
left a comment
There was a problem hiding this comment.
There are some misleading descriptions and commented out directives in the test configurations. I know you just copied them, but it should still be improved.
The ACL for running the messages command is now fixed. However, if I understand it correctly, you will still see the line "you have messages" when there are messages in the buffer even if you don't have access to the messages command.
This should probably also be addressed.
| Description = "Restricted console used by tray-monitor to get the status of the director." | ||
| Password = "@dir_password@" | ||
| CommandACL = status, .status | ||
| #JobACL = *all* |
There was a problem hiding this comment.
| #JobACL = *all* |
| Description = "Restricted console used by tray-monitor to get the status of the director." | ||
| Password = "@dir_password@" | ||
| CommandACL = status, .status, configure | ||
| #JobACL = *all* |
There was a problem hiding this comment.
| #JobACL = *all* |
| #CommandACL = status, .status | ||
| #JobACL = *all* |
There was a problem hiding this comment.
| #CommandACL = status, .status | |
| #JobACL = *all* |
| @@ -0,0 +1,7 @@ | |||
| Console { | |||
| Name = bareos-acl-none | |||
| Description = "Restricted console used by tray-monitor to get the status of the director." | |||
There was a problem hiding this comment.
The description is misleading, as there is no ACL restriction here. Either update the description or remove it.
| @@ -0,0 +1,7 @@ | |||
| Console { | |||
| Name = bareos-acl-status-conf | |||
| Description = "Restricted console used by tray-monitor to get the status of the director." | |||
There was a problem hiding this comment.
The description is misleading, as there is no ACL restriction here. Either update the description or remove it.
| @@ -0,0 +1,7 @@ | |||
| Console { | |||
| Name = bareos-acl-status | |||
| Description = "Restricted console used by tray-monitor to get the status of the director." | |||
There was a problem hiding this comment.
The description is misleading, as there is no ACL restriction here. Either update the description or remove it.
03f10cf to
c5453d5
Compare
646d18a to
336baa8
Compare
deleted descriptions and commented out directives
Fixes bareos#1329: If CommandACL limits any command, no messages can be read but "you have messages" is displayed.
336baa8 to
0d0180b
Compare
Thank you for contributing to the Bareos Project!
Description
When using the bconsole in the restricted mode, messages could not be showed to the user with the
messagescommand even though messages were available. This PR aims to fix that issue.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
check-sources --since-mergedoes not report any problems