db create: reflect currently available versions#709
Merged
franku merged 1 commit intobareos:masterfrom Jan 30, 2021
thbff:patch-1
Merged
db create: reflect currently available versions#709franku merged 1 commit intobareos:masterfrom thbff:patch-1
franku merged 1 commit intobareos:masterfrom
thbff:patch-1
Conversation
Contributor
thbff
commented
Jan 10, 2021
- added postgresql 13 so that possibly new install won't end up with LC_ parameters unset
- as versions prior 8.4 are far beyond EOL, that part might be reworked a bit more "drastically" I guess (but have no idea what needs to be yet supported, so patching it this simple way)
franku
reviewed
Jan 15, 2021
franku
suggested changes
Jan 29, 2021
Contributor
franku
left a comment
There was a problem hiding this comment.
We would like to merge your PR. There are some things to be done, yet:
- squash your commits to one and give it a reasonable description i.e. "scripts: cleanup code for postgresql db creation"
- add yourself to the AUTHORS list if you want
- add a short description to the CHANGELOG including the number of your PR using this syntax [PR #709], it will be automatically updated to a link when we create a release
Thanks for contribution!
Contributor
Author
think this is up to you as squash will happen during a merge, right?
actually, I just removed lines and did not add anything new ;-)
added, should merge flawlessly with the current file
my pleasure, thanks for the software! |
Contributor
We will be happy if you want to do that, would you? |
Contributor
Author
|
I see, ok, I was not aware of the workflow (nor the rebase squash possibility), that's my first one on github, had to try a few times aside before push. It should hopefully be ready now... |
franku
approved these changes
Jan 30, 2021
Contributor
|
Good work, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.