Skip to content

db create: reflect currently available versions#709

Merged
franku merged 1 commit intobareos:masterfrom
thbff:patch-1
Jan 30, 2021
Merged

db create: reflect currently available versions#709
franku merged 1 commit intobareos:masterfrom
thbff:patch-1

Conversation

@thbff
Copy link
Contributor

@thbff thbff commented Jan 10, 2021

  • added postgresql 13 so that possibly new install won't end up with LC_ parameters unset
  • as versions prior 8.4 are far beyond EOL, that part might be reworked a bit more "drastically" I guess (but have no idea what needs to be yet supported, so patching it this simple way)

Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to merge your PR. There are some things to be done, yet:

  • squash your commits to one and give it a reasonable description i.e. "scripts: cleanup code for postgresql db creation"
  • add yourself to the AUTHORS list if you want
  • add a short description to the CHANGELOG including the number of your PR using this syntax [PR #709], it will be automatically updated to a link when we create a release

Thanks for contribution!

@thbff
Copy link
Contributor Author

thbff commented Jan 29, 2021

We would like to merge your PR. There are some things to be done, yet:

* squash your commits to one and give it a reasonable description i.e. "scripts: cleanup code for postgresql db creation"

think this is up to you as squash will happen during a merge, right?

* add yourself to the AUTHORS list if you want

actually, I just removed lines and did not add anything new ;-)

* add a short description to the CHANGELOG including the number of your PR using this syntax [PR #709], it will be automatically updated to a link when we create a release

added, should merge flawlessly with the current file

Thanks for contribution!

my pleasure, thanks for the software!

@franku
Copy link
Contributor

franku commented Jan 29, 2021

  1. We usually do not squash or reword commits in PR branches, therefore it is up to the author. If you need help, we can do.
  2. AUTHORS file is a list of contributors. Therefore your name should be there.

We will be happy if you want to do that, would you?

@thbff
Copy link
Contributor Author

thbff commented Jan 29, 2021

I see, ok, I was not aware of the workflow (nor the rebase squash possibility), that's my first one on github, had to try a few times aside before push. It should hopefully be ready now...

@franku
Copy link
Contributor

franku commented Jan 30, 2021

Good work, thank you!

@franku franku merged commit 03c0cde into bareos:master Jan 30, 2021
@thbff thbff deleted the patch-1 branch February 2, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants