Merged
Conversation
franku
approved these changes
Sep 22, 2020
Contributor
franku
left a comment
There was a problem hiding this comment.
Good work!
I added some suggestions using extra commits on your branch.
661a217 to
04f7d1a
Compare
arogge
approved these changes
Sep 24, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
Some file-headers still have the wrong date in them.
Maybe we should probably have a tool for that...
Devices are no config file resources. They are only used internally, to represent Storages.
The code to parse a schedule run directive calls the scan_err function in case of a parse error. However, it did assume, that scan_err terminates the director. While this is true when parsing at the start of the director, it isn't true, when called by the "configure add" command. This patch improves the error handling, by exiting the parse function when an error is detected.
This change improves the handling of output from the "delete" command. The changes are required to access the individual jobids in the list, instead of having only access to the a string containing the comma seperated list of jobids. The count() function has been replaced with the standard size() function. The reset() function has been replaced with the standard clear() function. cleanup cleanup
This config type has been introduced recently and wasn't handled by PropagateResource (Job/JobDefs).
- adds a bit more readability to the code
04f7d1a to
909948c
Compare
alaaeddineelamri
pushed a commit
to alaaeddineelamri/bareos
that referenced
this pull request
Sep 30, 2020
…mds-fixes Improve some console commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves some console commands. It prevents some Director crashes and adds output for API mode 2 (JSON).