cram-md5: do not accept challenge if own hostname is used#536
Merged
Conversation
3de815d to
693cbcf
Compare
pstorz
reviewed
Jun 8, 2020
pstorz
approved these changes
Jun 8, 2020
Member
pstorz
left a comment
There was a problem hiding this comment.
Very good, this way the log messages are very
helpful.
6116ef7 to
52ffda7
Compare
franku
commented
Jun 9, 2020
franku
commented
Jun 9, 2020
franku
commented
Jun 9, 2020
c6caf94 to
c116dae
Compare
Contributor
Author
|
Force pushed after hands-on review with arogge. |
ccc1be6 to
81e2b03
Compare
arogge
approved these changes
Jun 18, 2020
Member
arogge
left a comment
There was a problem hiding this comment.
Looks good overall.
However, the test for two storages with different names is missing.
Maybe we should also find a better name for "Challenge Attack".
Fixes #1250: Authentication bypass in Director use the unified-resource-name for the cram challenge i.e. auth cram-md5 <1001326377.1591525437@R_CLIENT::backup-bareos-test-fd>
b7e6d21 to
ae8d9e8
Compare
ae8d9e8 to
a105df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on master