Skip to content

testfind: remove unnecessary libraries and fix systemtest#1250

Merged
pstorz merged 5 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/fix-testfind-libraries
Oct 24, 2022
Merged

testfind: remove unnecessary libraries and fix systemtest#1250
pstorz merged 5 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/fix-testfind-libraries

Conversation

@HediBenFraj
Copy link
Contributor

@HediBenFraj HediBenFraj commented Sep 7, 2022

Description

This pr is meant to remove unnecessary libraries linked to testfind bareossql and fix previous issues found with the testfind systemtest

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@HediBenFraj HediBenFraj changed the title testfind: remove unecessary libraries and fixe systemtest testfind: remove unecessary libraries and fix systemtest Sep 7, 2022
@HediBenFraj HediBenFraj marked this pull request as draft September 7, 2022 15:02
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, please see comments.

@HediBenFraj HediBenFraj requested a review from pstorz September 8, 2022 08:15
@HediBenFraj HediBenFraj marked this pull request as ready for review September 16, 2022 11:37
@pstorz pstorz changed the title testfind: remove unecessary libraries and fix systemtest testfind: remove unnecessary libraries and fix systemtest Sep 19, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a conflict currently. Maybe it makes sense to revert the CHANGELOG.md entry for now

@pstorz pstorz self-assigned this Sep 19, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/fix-testfind-libraries branch from b4aa982 to ddeec4b Compare September 19, 2022 08:50
@pstorz pstorz force-pushed the dev/HediBenFraj/master/fix-testfind-libraries branch from df88d36 to fe1edaa Compare September 19, 2022 15:30
@arogge arogge added the onhold label Oct 6, 2022
@pstorz pstorz force-pushed the dev/HediBenFraj/master/fix-testfind-libraries branch from c6286af to 0002a0d Compare October 20, 2022 12:30
@pstorz pstorz removed the onhold label Oct 20, 2022
@pstorz pstorz force-pushed the dev/HediBenFraj/master/fix-testfind-libraries branch from 563a87f to e8b9042 Compare October 24, 2022 08:30
@pstorz pstorz force-pushed the dev/HediBenFraj/master/fix-testfind-libraries branch from e8b9042 to 9f2f2c3 Compare October 24, 2022 08:32
@pstorz pstorz merged commit 2e24fad into bareos:master Oct 24, 2022
@pstorz pstorz deleted the dev/HediBenFraj/master/fix-testfind-libraries branch October 24, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants