Ceph Rados: added id argument to specify rados client id#49
Ceph Rados: added id argument to specify rados client id#49Crapworks wants to merge 3 commits intobareos:masterfrom Crapworks:master
Conversation
|
Hi, Thanks for adding this. When we wrote the support rados_create2 was not available so that I would also like to rebase things into 2 commits e.g. one for the rados-fd and one for the backend. |
|
Hi Marco, I see! I will have a closer look at the ceph integration in the next time. This is just a quick fix so we can use a non-admin key in our infrastructure and I wanted to make sure it will find it's way to upstream. I will have a look at a rados_create2() integration as well in the next time. Did a rebase to combine the last commits. Cheers, |
|
I think there is one typo in the patch for the storage backend. { "id=", argument_id, 9 }, should probably be { "id=", argument_id, 3 }, Maybe we should also call it clientid ? |
|
Hi, I changed the name to clientid. |
|
I see one typo e.g. clientd instead of clientid. |
- using the right icons in the dialogs - cleanup of text formatting - added help text for /D, /S and /? params - commented out catalog directive in generated config this is also described in a comment - fixes uninstall problem on win64 Fixes: bareos#49 : Install Parameters and Helptext for cmd installation Fixes: bareos#121 : Deinstallation of windows installer works, but is not removed from the software list in windows. Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>
…ration Adapted pam_exec_add_bareos_user.py to Bareos >= 19.2.4
Hi all,
thanks for adding ceph rados support to bareos! As it is right now, you have no other choice than to use the client.admin key on bareos, because there is no way to specify a client id for
rados_create(). I've added a config option "id" where the user can specify a client id.Since you are using
rados_create()and notrados_create2()the value should be "admin", not "client.admin".Cheers,
Christian