Skip to content

Ceph Rados: added id argument to specify rados client id#49

Closed
Crapworks wants to merge 3 commits intobareos:masterfrom
Crapworks:master
Closed

Ceph Rados: added id argument to specify rados client id#49
Crapworks wants to merge 3 commits intobareos:masterfrom
Crapworks:master

Conversation

@Crapworks
Copy link

Hi all,

thanks for adding ceph rados support to bareos! As it is right now, you have no other choice than to use the client.admin key on bareos, because there is no way to specify a client id for rados_create(). I've added a config option "id" where the user can specify a client id.

Since you are using rados_create() and not rados_create2() the value should be "admin", not "client.admin".

Cheers,
Christian

@mvwieringen
Copy link
Contributor

Hi,

Thanks for adding this. When we wrote the support rados_create2 was not available so that
explains why we didn't use it. You could add support for it if you add it in the same way we
support the changed write API e.g. #if LIBRADOS_VERSION_CODE <= 17408
you only need to find out since which version rados_create2 is part of API.

I would also like to rebase things into 2 commits e.g. one for the rados-fd and one for the backend.
As far as I can see the two others are mostly fixes to one of the previous ones.

@Crapworks
Copy link
Author

Hi Marco,

I see! I will have a closer look at the ceph integration in the next time. This is just a quick fix so we can use a non-admin key in our infrastructure and I wanted to make sure it will find it's way to upstream. I will have a look at a rados_create2() integration as well in the next time.

Did a rebase to combine the last commits.

Cheers,
Christian

@mvwieringen
Copy link
Contributor

I think there is one typo in the patch for the storage backend.

{ "id=", argument_id, 9 },

should probably be

{ "id=", argument_id, 3 },

Maybe we should also call it clientid ?
If you can fix that then I can merge the pull request.

@Crapworks
Copy link
Author

Hi, I changed the name to clientid.

@mvwieringen
Copy link
Contributor

I see one typo e.g. clientd instead of clientid.
I close the pull request just saved the patches and will commit them after some cleanups under your name in master. So it will be visible by the end of the week when we sync to github.

@mvwieringen mvwieringen closed this Feb 1, 2016
arogge pushed a commit to bareos-testing/bareos that referenced this pull request Nov 13, 2019
- using the right icons in the dialogs
- cleanup of text formatting
- added help text for /D, /S and /? params
- commented out catalog directive in generated config
  this is also described in a comment
- fixes uninstall problem on win64

  Fixes: bareos#49  : Install Parameters and Helptext for cmd installation
  Fixes: bareos#121 : Deinstallation of windows installer works, but is not removed from the software list in windows.

Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>
franku pushed a commit that referenced this pull request Feb 25, 2021
…ration

Adapted pam_exec_add_bareos_user.py to Bareos >= 19.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants