Skip to content

webui: Fix sorting of job selection in restore module#411

Merged
frb121 merged 1 commit intomasterfrom
dev/fbergkemper/master/webui-fix-job-sort-in-restore-module
Feb 10, 2020
Merged

webui: Fix sorting of job selection in restore module#411
frb121 merged 1 commit intomasterfrom
dev/fbergkemper/master/webui-fix-job-sort-in-restore-module

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Feb 6, 2020

A recent bconsole command change in the getClientBackups method
of the client model lead to a wrong population of the backup job
selection to choose from in the restore module.

To fix this issue the population of the backup job selection list is
still done by the getClientBackups method but with the proper bconsole
command as it has been before.

The client details action now calls the getClientJobs method of the
client model to get a job list with all status instead a list of
successful backup jobs only.

Fixes #1174: reversed sort order on the restore client selection

A recent bconsole command change in the getClientBackups method
of the client model lead to a wrong population of the backup job
selection to choose from in the restore module.

To fix this issue the population of the backup job selection list is
still done by the getClientBackups method but with the proper bconsole
command as it has been before.

The client details action now calls the getClientJobs method of the
client model to get a job list with all status instead a list of
successful backup jobs only.

Fixes #1174: reversed sort order on the restore client selection
@frb121 frb121 requested a review from franku February 6, 2020 14:45
Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@frb121 frb121 merged commit 2b58f17 into master Feb 10, 2020
@frb121 frb121 deleted the dev/fbergkemper/master/webui-fix-job-sort-in-restore-module branch February 10, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants