libcloud plugin: storage provider config#1174
Closed
mat1010 wants to merge 1 commit intobareos:bareos-21from
Closed
libcloud plugin: storage provider config#1174mat1010 wants to merge 1 commit intobareos:bareos-21from
mat1010 wants to merge 1 commit intobareos:bareos-21from
Conversation
Right now S3 is hardcoded within the provider type for the apache libcloud plugin. Any other value, in the config_file parameter for "provider" will not be respected. With this change the option will be actually used.
Member
|
Sorry for the really long wait. I assume you have tested this and it worked for you? |
arogge
approved these changes
Jun 21, 2022
Contributor
Author
|
Thank you. Yes, we are using it on our production system. No issues so far. |
Member
|
Just in case you wondered why we didn't merge the PR yet. It is missing documentation and a changelog record. I will gladly add both once I return from vacation (around July 18th), but unless somebody else is willing to take care of this, it will continue to wait for now. |
17 tasks
Member
|
Hello, thank you again for your contribution. As we usually only merge new fetures into the master branch, I created a new PR #1226 containing your changes based on master and which will be merged today. best regards, Philipp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now S3 is hardcoded within the provider type
for the apache libcloud plugin. Any other value, in
the config_file parameter for "provider" will not
be respected.
With this change the option will be actually used.
We were able to successfully test this change with S3 and S3_RGW providers.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests