libcloud plugin: libcloud storage provider config#1226
Merged
Conversation
3e93171 to
c78c8b1
Compare
bruno-at-bareos
approved these changes
Aug 16, 2022
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice work, thanks contributing.
17 tasks
Right now S3 is hardcoded within the provider type for the apache libcloud plugin. Any other value, in the config_file parameter for "provider" will not be respected. With this change the option will be actually used. (cherry picked from commit ae36762)
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
090d934 to
4a1f372
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is a port of PR #1174 to master
Right now S3 is hardcoded within the provider type
for the apache libcloud plugin. Any other value, in
the config_file parameter for "provider" will not
be respected.
With this change the option will be actually used.
(cherry picked from commit ae36762)
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests