Skip to content

webui: replace !empty() with strlen()>0#321

Merged
arogge merged 1 commit intobareos:masterfrom
arogge:dev/arogge/master/webui-php54-compat
Nov 6, 2019
Merged

webui: replace !empty() with strlen()>0#321
arogge merged 1 commit intobareos:masterfrom
arogge:dev/arogge/master/webui-php54-compat

Conversation

@arogge
Copy link
Member

@arogge arogge commented Nov 6, 2019

In PHP versions prior to 5.5 (as e.g. on RHEL/CentOS 7) empty() can only
be used with variables and not function return values.

In PHP versions prior to 5.5 (as e.g. on RHEL/CentOS 7) empty() can only
be used with variables and not function return values.
@arogge arogge requested a review from frb121 November 6, 2019 12:31
Copy link
Contributor

@frb121 frb121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge please

@arogge arogge merged commit 2880631 into bareos:master Nov 6, 2019
@arogge arogge deleted the dev/arogge/master/webui-php54-compat branch November 6, 2019 15:05
florian-at-bareos added a commit to florian-at-bareos/bareos that referenced this pull request Apr 15, 2025
using the flags
"--indent 2 --binary-next-line --case-indent --func-next-line" as in
issue bareos#321
florian-at-bareos added a commit to florian-at-bareos/bareos that referenced this pull request Apr 15, 2025
using the flags
"--indent 2 --binary-next-line --case-indent --func-next-line" as in
issue bareos#321
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Apr 16, 2025
partial backport of master commit 86f8233

using the flags
"--indent 2 --binary-next-line --case-indent --func-next-line" as in
issue bareos#321

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
BareosBot pushed a commit to bruno-at-bareos/bareos that referenced this pull request Apr 16, 2025
partial backport of master commit 86f8233

using the flags
"--indent 2 --binary-next-line --case-indent --func-next-line" as in
issue bareos#321

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants