table-formatter.js: Fix icon selection logic#2481
Merged
BareosBot merged 2 commits intobareos:bareos-25from Dec 12, 2025
Merged
table-formatter.js: Fix icon selection logic#2481BareosBot merged 2 commits intobareos:bareos-25from
BareosBot merged 2 commits intobareos:bareos-25from
Conversation
This fixes two problems: - It is not useful here to construct a map, and its iteration is broken (`values()` doesn’t do what’s expected here); - The Windows case would catch `darwin` because it contains `win`. Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr> (cherry picked from commit 0903e1b)
6dc7e84 to
af5b083
Compare
pstorz
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2479 to bareos-25
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality (if there were changes to the original PR)
Backport quality