table-formatter.js: Fix icon selection logic#2479
Merged
BareosBot merged 2 commits intobareos:masterfrom Dec 12, 2025
Merged
Conversation
Contributor
Author
|
Before: |
Contributor
|
Do you want to add yourself to the AUTHORS file ? |
Contributor
Author
|
Let’s wait for a big contribution, I’m not in a hurry :) |
sebsura
approved these changes
Dec 12, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
7 tasks
This fixes two problems: - It is not useful here to construct a map, and its iteration is broken (`values()` doesn’t do what’s expected here); - The Windows case would catch `darwin` because it contains `win`. Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
0903e1b to
90c418c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems:
values()doesn’t do what’s expected here);darwinbecause it containswin.Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality