Skip to content

rpm: don't fail, if install log file isn't writable#2477

Merged
BareosBot merged 5 commits intobareos:bareos-25from
joergsteffens:backport/bareos-25/rpm-immutable
Dec 16, 2025
Merged

rpm: don't fail, if install log file isn't writable#2477
BareosBot merged 5 commits intobareos:bareos-25from
joergsteffens:backport/bareos-25/rpm-immutable

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Dec 8, 2025

Backport of PR #2473 to bareos-25

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Correct milestone is set
Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

@joergsteffens joergsteffens added enhancement bug This addresses a bug is a backport to 25 This is a backport from master to bareos-25 labels Dec 8, 2025
@joergsteffens joergsteffens self-assigned this Dec 8, 2025
@joergsteffens joergsteffens added this to the 25.0.2 milestone Dec 8, 2025
@bruno-at-bareos
Copy link
Contributor

I'm missing the second commit

714be41

@joergsteffens joergsteffens marked this pull request as draft December 9, 2025 14:22
@bruno-at-bareos
Copy link
Contributor

@joergsteffens kind reminder #2473 is now merged, so you can redo the cherry-picking of all commit to this one and move it out of draft.

joergsteffens and others added 4 commits December 15, 2025 16:14
As our RPM installation handles some complex update scenarios
it write to an install log file.
On some systems, it is not possible to write log files,
because /var is read-only. Specifically this is the case on immutable
systems like Fedora Silverblue. In that case, we write to stdout.

Fix bareos#2465

(cherry picked from commit 37b04ab)
`useradd` long parameter for home is --home-dir

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit fdcb8c5)
add some spaces, mostly to be better comparable with
bareos-universal-client.spec.

(cherry picked from commit 4b38b68)
Try to make bareos.spec and bareos-universal-client.spec s similar as
possible.

(cherry picked from commit e94e8a3)
@joergsteffens joergsteffens force-pushed the backport/bareos-25/rpm-immutable branch from 24c0106 to d1bda74 Compare December 15, 2025 15:17
@joergsteffens joergsteffens marked this pull request as ready for review December 15, 2025 15:17
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those nice enhancements

@bruno-at-bareos
Copy link
Contributor

Normal rpm and universal resulting package tested ok.

@BareosBot BareosBot merged commit add249a into bareos:bareos-25 Dec 16, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug enhancement is a backport to 25 This is a backport from master to bareos-25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants