rpm: don't fail, if install log file isn't writable#2473
Merged
Conversation
Member
Author
|
Confirmed to work also on Fedora Silverblue in #2465 |
bruno-at-bareos
requested changes
Dec 8, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for the fixes, I would like to see them spelled constantly like other.
Please also prepare backport for 25.
fa8e654 to
46d4d4c
Compare
6 tasks
5a82996 to
d4f1ead
Compare
Member
Author
|
Extended the PR with changes for the Bareos Universal Linux Client. |
bruno-at-bareos
approved these changes
Dec 15, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Great enhancement thanks, approved!
As our RPM installation handles some complex update scenarios it write to an install log file. On some systems, it is not possible to write log files, because /var is read-only. Specifically this is the case on immutable systems like Fedora Silverblue. In that case, we write to stdout. Fix #2465
`useradd` long parameter for home is --home-dir Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
add some spaces, mostly to be better comparable with bareos-universal-client.spec.
Try to make bareos.spec and bareos-universal-client.spec s similar as possible.
de3e2ed to
6cccf0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As our RPM installation handles some complex update scenarios it write to an install log file.
On some systems, it is not possible to write log files, because /var is read-only. Specifically this is the case on immutable systems like Fedora Silverblue. In that case, we write to stdout.
Fix #2465
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Required documentation changes are present and part of the PR