Merged
Conversation
arogge
previously requested changes
Nov 24, 2025
Member
arogge
left a comment
There was a problem hiding this comment.
I'm not (yet) happy with the os-release parsing and the missing fallback.
osinfo.cc should probably be renamed to osinfo_unix.cc or something like that.
We also need to look into how to do this properly on MacOS, as probably neither os-release nor struct utsname provide the output we want.
sebsura
reviewed
Nov 26, 2025
sebsura
reviewed
Nov 26, 2025
80bf142 to
7a9763c
Compare
sebsura
approved these changes
Nov 27, 2025
(cherry picked from commit 5a09f0c)
VSS is either "" or " VSS", so there should _never_ be a space before %s. As the string is static, it also doesnt make sense to format it at runtime, so I simply added in directly into the format string.
280c8dd to
ed2ac02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR contains the commits for runtime OS detection from PR #2346
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality