core: lots of test fixes, some crash fixes, switch to registry for windows version name#2346
Draft
sebsura wants to merge 16 commits intobareos:masterfrom
Draft
core: lots of test fixes, some crash fixes, switch to registry for windows version name#2346sebsura wants to merge 16 commits intobareos:masterfrom
sebsura wants to merge 16 commits intobareos:masterfrom
Conversation
Contributor
|
I love the make the windows daemons actually report the runtime windows version. Do you think to certain extent it would be possible for *nix daemon to do the same ? |
2fced48 to
b59aabe
Compare
time_t is a 64bit signed value. Currently python truncates our times to 32bit unsigned values. These truncation cause (previously silenced) warnings that become visible when used under grpc.
There is no need to run the same commands twice here ...
The computation is just wrong even in our simple example. Im not sure why this solution does not work, but it seems much simpler.
if this error popped up during a test it was not clear at all what exactly broke. At least now you can immediately see that the problem is in some expect_grep invocation.
Now the test actually checks if bscan correctly recovered the size of the disk.
When we copy configuration pointers from one jcr to the next, we need to make sure that the configuration actually stays alive. To do this we simply copy the configuration container from the old jcr into the new jcr, as that container keeps alive everything that we need. Maybe we should instead try to match the resources to their new counterpart ?
b59aabe to
cc8ed7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This pr
nullptra validPOOLMEM*,The last part should also be done on *nix as well.
TODO:
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests