Merged
Conversation
fffebe1 to
8c81e67
Compare
sebsura
previously requested changes
Oct 17, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I still have to try to understand some changes but here are already some comments.
b1fcc4a to
fd401ef
Compare
sebsura
requested changes
Oct 29, 2025
sebsura
requested changes
Oct 29, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Great work. Just a few simple things left to do.
daa379d to
3b70adf
Compare
sebsura
approved these changes
Oct 30, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for the awesome work! Its so much better now
- remove shipping in rpm packages - adapt sourcing for tests - use BareosSystemtestFunctions.cmake for bareos-ctl-* configuration
- add copyright/license when missing - set surrounding bracket around var when missing - when needed use explicit local_conf variable instead previous global conf - fix indentation
systemtests doesn't need nor use specific user/group This mainly revert b2735de
- enable copy-remote-bscan systemtests - setup temporaly configuration with new variable Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- avoid relative path ../ in variable - use variable name which are not command
The only consumer of this script is systemtests, so we move it there. functions is revisited to use `bin/bareos` Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
2a418a9 to
7689c17
Compare
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to bring uniformization in variables used in core and tests scripts.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests