VMWare Plugin: Fix VirtualSerialPort, NVRAM timeouts configurable#2344
Merged
BareosBot merged 4 commits intobareos:masterfrom Aug 19, 2025
Merged
Conversation
The VMware Plugin can now save and recreate VMs with VirtualSerialPort devices. This commit also contains documentation changes about the VDDK Version which was updated to 9.0 and some improvements about the installation of required Python modules.
The connection timeout the read/write timeout when backing up or restoring the NVRAM file are configurable now, also appropriate default values are used.
bruno-at-bareos
requested changes
Aug 19, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Excellent improvement.
A few recommendation coming from pylint can be applied.
Here's the additional one we might be interested to have.
Line 3632
R1701: Consider merging these isinstance calls to isinstance(file_content, (bytearray, bytes)) (consider-merging-isinstance)
Requested changes for PR bareos#2344 and a few more suggested by pylint.
bruno-at-bareos
approved these changes
Aug 19, 2025
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Excellent improvement, thanks for the good work!
Approved
bruno-at-bareos
pushed a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Aug 19, 2025
Requested changes for PR bareos#2344 and a few more suggested by pylint. (cherry picked from commit da4f83c)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VMware Plugin can now save and recreate VMs with VirtualSerialPort devices.
The VMware Plugin have now NVRAM backup/restore timeouts configurable and have improved defaults.
This commit also contains documentation changes about the VDDK Version which was updated to 9.0 and some improvements about the installation of required Python modules.
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality