Skip to content

VMware Plugin: Adapt to pyVmomi 9#2341

Merged
BareosBot merged 3 commits intobareos:masterfrom
sduehr:dev/sduehr/master/fix-vmware-plugin-pyvmomi9
Aug 13, 2025
Merged

VMware Plugin: Adapt to pyVmomi 9#2341
BareosBot merged 3 commits intobareos:masterfrom
sduehr:dev/sduehr/master/fix-vmware-plugin-pyvmomi9

Conversation

@sduehr
Copy link
Member

@sduehr sduehr commented Aug 8, 2025

The import of the VmomiJSONEncoder was changed in pyVmomi9, this change adapts the Bareos VMware plugin so that it works with both the new and the old pyVmomi versions.

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)

@sduehr sduehr linked an issue Aug 8, 2025 that may be closed by this pull request
@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Aug 12, 2025
@bruno-at-bareos bruno-at-bareos self-requested a review August 12, 2025 10:04
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except an adjustment to comment, it's fine
Maybe you want to be explicit about the new call in 9x inside the commit description?

sduehr added a commit to sduehr/bareos that referenced this pull request Aug 13, 2025
@sduehr sduehr requested a review from bruno-at-bareos August 13, 2025 10:40
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks.

bruno-at-bareos pushed a commit to bruno-at-bareos/bareos that referenced this pull request Aug 13, 2025
(cherry picked from commit 6787c13)
sduehr and others added 3 commits August 13, 2025 12:44
The import of the VmomiJSONEncoder was changed in pyVmomi9, this change
adapts the Bareos VMware plugin so that it works with both the new and
the old pyVmomi versions.
@BareosBot BareosBot force-pushed the dev/sduehr/master/fix-vmware-plugin-pyvmomi9 branch from c85ecd0 to b2f4cdc Compare August 13, 2025 12:45
@BareosBot BareosBot merged commit 37cc468 into bareos:master Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VMWare plugin incompatible to PyVmomi 9

3 participants