Skip to content

Bugfix for #1072 (Newer versions of Fedora use stricter code checking)#228

Merged
arogge merged 2 commits intobareos:masterfrom
tuxmaster5000:0001072
Sep 3, 2019
Merged

Bugfix for #1072 (Newer versions of Fedora use stricter code checking)#228
arogge merged 2 commits intobareos:masterfrom
tuxmaster5000:0001072

Conversation

@tuxmaster5000
Copy link
Contributor

@arogge
Copy link
Member

arogge commented Jul 15, 2019

Hi, thanks for the PR!
I'd really like to fix this problem. However, the line you propose the change for is probably better off by replacing it with strncpy().
The real issue is that our cmake config doesn't enable -Werror=format-security by default. We should fix that one!

@tuxmaster5000
Copy link
Contributor Author

Exhange the patched.

@arogge arogge requested a review from franku July 16, 2019 07:18
@arogge
Copy link
Member

arogge commented Jul 16, 2019

Sorry, that one doesn't (yet) build on MacOS. The Xcode version we're using flags gettext strings as "not a string literal" which then triggers the format-security error.

@arogge
Copy link
Member

arogge commented Jul 18, 2019

I guess we will need to upgade the Xcode on our Mac build system before we can merge this.
This might take some time. Sorry.

@arogge
Copy link
Member

arogge commented Aug 30, 2019

I finally managed to get the MacOS builds working with a newer XCode version.
Not all tests have finished yet, but I think we will be able to merge this next week.

@arogge arogge merged commit df5a1b3 into bareos:master Sep 3, 2019
@tuxmaster5000 tuxmaster5000 deleted the 0001072 branch September 4, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants