console: multicolumn output: fill columns first#1072
Merged
Conversation
arogge
reviewed
Feb 16, 2022
ee02291 to
4d5e720
Compare
4c7ce67 to
5842b45
Compare
4be2c6b to
ce07e27
Compare
a2b2945 to
1443eaa
Compare
1443eaa to
3691e4b
Compare
3691e4b to
de6e844
Compare
pstorz
commented
Mar 18, 2022
Member
Author
pstorz
left a comment
There was a problem hiding this comment.
Just one small typo in the comment!
Good work!
de6e844 to
0205868
Compare
13 tasks
0205868 to
5fdc4a1
Compare
alaaeddineelamri
approved these changes
Mar 18, 2022
pstorz
commented
Mar 18, 2022
5fdc4a1 to
d3294c1
Compare
`FormatPrompts` instead of `FormatMulticolumnPrompts` makes more sense since the function does multicolumn only on certain conditions Changed test names accordingly
d3294c1 to
1e362b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The multicolumn output puts the items line by line like this:
This PR make the output look like this:
Which is much better for human consumption.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
- [ ] Required documentation changes are present and part of the PRbareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests