Skip to content

console: multicolumn output: fill columns first#1072

Merged
pstorz merged 5 commits intomasterfrom
dev/pstorz/master/multicolumn-output-vertical
Mar 18, 2022
Merged

console: multicolumn output: fill columns first#1072
pstorz merged 5 commits intomasterfrom
dev/pstorz/master/multicolumn-output-vertical

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Feb 16, 2022

Thank you for contributing to the Bareos Project!

The multicolumn output puts the items line by line like this:

1  2  3  
4  5  6
7  8  9 

This PR make the output look like this:

1  4  7
2  5  8
3  6  9

Which is much better for human consumption.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
    - [ ] Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@pstorz pstorz marked this pull request as draft February 16, 2022 09:10
@pstorz pstorz self-assigned this Feb 17, 2022
@arogge arogge assigned alaaeddineelamri and unassigned pstorz Feb 24, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from ee02291 to 4d5e720 Compare February 28, 2022 19:32
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review March 1, 2022 06:34
@pstorz pstorz force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 4c7ce67 to 5842b45 Compare March 1, 2022 15:38
@pstorz pstorz changed the title console: multicolumn output: fill colums first console: multicolumn output: fill columns first Mar 1, 2022
@pstorz pstorz force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 4be2c6b to ce07e27 Compare March 1, 2022 16:14
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch 2 times, most recently from a2b2945 to 1443eaa Compare March 3, 2022 13:09
@pstorz pstorz closed this Mar 10, 2022
@pstorz pstorz deleted the dev/pstorz/master/multicolumn-output-vertical branch March 10, 2022 12:00
@pstorz pstorz restored the dev/pstorz/master/multicolumn-output-vertical branch March 10, 2022 12:08
@pstorz pstorz reopened this Mar 10, 2022
@pstorz pstorz closed this Mar 10, 2022
@pstorz pstorz deleted the dev/pstorz/master/multicolumn-output-vertical branch March 10, 2022 12:34
@pstorz pstorz restored the dev/pstorz/master/multicolumn-output-vertical branch March 15, 2022 12:58
@pstorz pstorz reopened this Mar 15, 2022
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 1443eaa to 3691e4b Compare March 15, 2022 13:07
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 3691e4b to de6e844 Compare March 17, 2022 13:51
Copy link
Member Author

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small typo in the comment!
Good work!

@pstorz pstorz requested a review from alaaeddineelamri March 18, 2022 09:35
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from de6e844 to 0205868 Compare March 18, 2022 09:54
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 0205868 to 5fdc4a1 Compare March 18, 2022 10:31
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from 5fdc4a1 to d3294c1 Compare March 18, 2022 11:11
Alaa Eddine Elamri and others added 4 commits March 18, 2022 12:19
`FormatPrompts` instead of `FormatMulticolumnPrompts` makes
more sense since the function does multicolumn only on certain
conditions
Changed test names accordingly
@alaaeddineelamri alaaeddineelamri force-pushed the dev/pstorz/master/multicolumn-output-vertical branch from d3294c1 to 1e362b9 Compare March 18, 2022 11:19
Copy link
Member Author

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@pstorz pstorz merged commit d15583f into master Mar 18, 2022
@pstorz pstorz deleted the dev/pstorz/master/multicolumn-output-vertical branch August 10, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants