fix autodeflate messages and refactor setup method#2121
Merged
BareosBot merged 11 commits intobareos:masterfrom Feb 24, 2025
Merged
fix autodeflate messages and refactor setup method#2121BareosBot merged 11 commits intobareos:masterfrom
BareosBot merged 11 commits intobareos:masterfrom
Conversation
sebsura
requested changes
Jan 20, 2025
ecfe24d to
20011f9
Compare
sebsura
requested changes
Feb 6, 2025
sebsura
approved these changes
Feb 10, 2025
sebsura
reviewed
Feb 20, 2025
35a02a5 to
0f374ac
Compare
4b3be65 to
5f6ac3b
Compare
Fixes bareos#1944: autoxflate lzo & visuals are broken Remove switch statement to avoid dangerous fallthrough with code in between which causes the problem (bareos#1944) in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1944: autoxflate lzo & visuals are broken
Remove switch statement to avoid dangerous fallthrough with code in
between which causes the problem (#1944) in the first place.
Note that I did a manual test and got the correct compressor names:
17-Jan 09:01 bareos-sd JobId 13: autoxflate-sd: Compressor on device FileStorage is LZ4
previously this would output LZ4HC besides LZ4 being specified
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality