Skip to content

autoxflate lzo & visuals are broken #1944

@pstorz

Description

@pstorz

Currently the autodeflate setup code looks like this:

switch (autodeflate) {
...
#if defined(HAVE_LZO)
    case COMPRESS_LZO1X:
      compressorname = COMPRESSOR_NAME_LZO;
      break; // nothing is set up; is this intentional ?
#endif
 
    case COMPRESS_FZFZ:
      compressorname = COMPRESSOR_NAME_FZLZ;
      [[fallthrough]];
    case COMPRESS_FZ4L:
      compressorname = COMPRESSOR_NAME_FZ4L;
      [[fallthrough]];
    case COMPRESS_FZ4H: {
      compressorname = COMPRESSOR_NAME_FZ4H; // compressor name is always overriden to FZ4H
      ...
     }
  ...
}
Jmsg(ctx, M_INFO, T_("autoxflate-sd: Compressor on device %s is %s\n"),
     dcr->dev_name, compressorname);

We need to

  • Check if lzo compression works
  • Fix the compressor name output if any FZ* algorithm is chosen.
    This can easily be done by checking compressorname == COMPRESSOR_NAME_UNSET before each assignment.

Metadata

Metadata

Labels

bugThis addresses a bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions