bconsole: enable app icon on windows#2105
Merged
BareosBot merged 10 commits intobareos:masterfrom Jan 24, 2025
Merged
Conversation
sebsura
requested changes
Jan 8, 2025
Contributor
|
Tested build .exe files in Bareos List of executable in taskmanager so still |
Contributor
|
i think this a good place to also fix bareos/internal#191 |
Contributor
|
@bruno-at-bareos look at a few comments above, I already mentioned that the sd still needs fixing :) |
Contributor
|
With version Bareos-25.0.0~pre55.bf7533be1-x64-Release.exe Tree icons is now fixed And all exe icons are okay Even Bareos-TrayMonitor is now again visible when running Need to be fixed deprecated configuration parameters are still present for the FD and SD |
bf7533b to
86c0feb
Compare
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
We need also the check the usage of "%TEMP%" during build but also when executable are run with user rights, like bconsole.
5c0d104 to
9cd63ea
Compare
7 tasks
sebsura
approved these changes
Jan 23, 2025
We cannot remove the header completely yet, as our infrastructure expects it to be there, but we can at least use the normal values for it.
If this option is set, then the tray monitor is instructed to create a debug trace in the given directory.
On windows its fine to have a bound socket on 127.0.0.1:X and 0.0.0.0:X, so the test fails as it expected this to not work. Thankfully binding 0.0.0.0:X twice _does_ still fail (like the other tests already show), so I just changed this test to be like the other ones and have the director bind on 0.0.0.0.
Some of our tests already include an explicit wait for the language select drop down to appear, see 'disabled_test_languages': > self.wait_and_click(By.XPATH, '//button[@data-id="locale"]') Hopefully this fixes the problem, where selenium cannot find the "English" selection during our ci tests.
12e273c to
3933a27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR will fix issue #2092 and bareos/internal#220
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests