Skip to content

plugins: Fix typo in postgresql plugin#2071

Merged
BareosBot merged 2 commits intobareos:bareos-24from
bruno-at-bareos:backport/bareos-24/fix-fd-postgres-syntax-error
Dec 16, 2024
Merged

plugins: Fix typo in postgresql plugin#2071
BareosBot merged 2 commits intobareos:bareos-24from
bruno-at-bareos:backport/bareos-24/fix-fd-postgres-syntax-error

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Dec 16, 2024

Backport of PR #2066 to bareos-24

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Correct milestone is set
Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

AlexanderS and others added 2 commits December 16, 2024 15:21
This is a typo introduced in 0901b6f
The parentheses are only used to group the string concatenation and
should not contain a comma. The error results in this error message:

> Fatal error: bareosfd: Traceback (most recent call last):
>  File "/usr/lib/bareos/plugins/BareosFdWrapper.py", line 94, in
>    restore_object_data
>    return bareos_fd_plugin_object.restore_object_data(rop)
>  File "/usr/lib/bareos/plugins/bareos-fd-postgresql.py", line 1546,
>   in restore_object_data
>    bareosfd.DebugMessage(
> TypeError: BareosDebugMessage() argument 2 must be str or None, not
>  tuple

and a failed backup job.

(cherry picked from commit 0a0e99a)
@BareosBot BareosBot force-pushed the backport/bareos-24/fix-fd-postgres-syntax-error branch from 4b6a31e to 260f5d5 Compare December 16, 2024 15:22
@BareosBot BareosBot merged commit a8ceb66 into bareos:bareos-24 Dec 16, 2024
@bruno-at-bareos bruno-at-bareos deleted the backport/bareos-24/fix-fd-postgres-syntax-error branch December 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants