plugins: Fix typo in postgresql plugin#2066
Merged
BareosBot merged 2 commits intobareos:masterfrom Dec 16, 2024
Merged
Conversation
Contributor
Author
Contributor
Author
|
I do not have access to the failing build in jenkins, but I doubt that the failure is related to this change. |
Member
Hello Alexander, you are right, the error is not caused by your change. I just triggered a new build and test run. Thank you for your contribution. |
7 tasks
bruno-at-bareos
approved these changes
Dec 16, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for pointing the trouble, and proposing the fix.
261932d to
0a0e99a
Compare
7 tasks
This is a typo introduced in 0901b6f The parentheses are only used to group the string concatenation and should not contain a comma. The error results in this error message: > Fatal error: bareosfd: Traceback (most recent call last): > File "/usr/lib/bareos/plugins/BareosFdWrapper.py", line 94, in > restore_object_data > return bareos_fd_plugin_object.restore_object_data(rop) > File "/usr/lib/bareos/plugins/bareos-fd-postgresql.py", line 1546, > in restore_object_data > bareosfd.DebugMessage( > TypeError: BareosDebugMessage() argument 2 must be str or None, not > tuple and a failed backup job.
0a0e99a to
6ede7ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a typo introduced in 0901b6f. The parentheses are only used to group the string concatenation and should not contain a comma. The error results in this error message:
and a failed backup job.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests