Skip to content

webui: fix for PHP < 7.3#2070

Merged
BareosBot merged 4 commits intobareos:bareos-24from
joergsteffens:backport/bareos-24/webui-restore-fix
Dec 16, 2024
Merged

webui: fix for PHP < 7.3#2070
BareosBot merged 4 commits intobareos:bareos-24from
joergsteffens:backport/bareos-24/webui-restore-fix

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Dec 16, 2024 •
edited by arogge
Loading

Backport of PR #2067 to bareos-24

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Correct milestone is set
Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

sebsura
sebsura approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsura sebsura added this to the 24.0.0 milestone Dec 16, 2024
joergsteffens and others added 4 commits December 16, 2024 17:08
@joergsteffens @BareosBot
webui: adapt for PHP < 7.3
373299f 
(cherry picked from commit 3297f05)
@joergsteffens @BareosBot
webui: removed unused variable
70b6b73 
The fileset index does not exist and is not used.
Removing this line prevent a PHP Notice.

(cherry picked from commit 357010b)
@joergsteffens @BareosBot
webui: selenium, set default value
ed47771 
(cherry picked from commit 0b1c6e7)
@BareosBot
Update CHANGELOG.md
95f7198
@BareosBot BareosBot force-pushed the backport/bareos-24/webui-restore-fix branch from 47b6cac to 95f7198 Compare December 16, 2024 17:09
@BareosBot BareosBot merged commit dabb777 into bareos:bareos-24 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura approved these changes

Assignees

No one assigned

Labels

bug This addresses a bug is a backport to 24

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@joergsteffens @sebsura @BareosBot